Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Change highlight author to github handles #160

Closed
1 of 2 tasks
bdougie opened this issue Jun 3, 2023 · 5 comments 路 Fixed by #162
Closed
1 of 2 tasks

Feature: Change highlight author to github handles #160

bdougie opened this issue Jun 3, 2023 · 5 comments 路 Fixed by #162

Comments

@bdougie
Copy link
Member

bdougie commented Jun 3, 2023

Type of feature

馃崟 Feature

Current behavior

Screen Shot 2023-06-02 at 8 50 02 PM

The author is displayed as a full name, but it should be the GitHub handle.

Suggested solution

The formatNameForLink is not needed on this line and instead of .name it should be .login

https://github.com/open-sauced/ai/pull/154/files#diff-7c8d28ff1de800f1a1770a7f9bf600faa23af4ef36b2b27e7af3cc0b4b473ff4R122

Additional context

Use login instead of name

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@bdougie
Copy link
Member Author

bdougie commented Jun 3, 2023

This is needed before we can release. #155

The links to the insight platform are linked to profiles that exist.

@bdougie bdougie self-assigned this Jun 3, 2023
@bdougie
Copy link
Member Author

bdougie commented Jun 3, 2023

@a0m0rajab or @Anush008 I am trying to change this line:

https://github.com/open-sauced/ai/pull/154/files#diff-7c8d28ff1de800f1a1770a7f9bf600faa23af4ef36b2b27e7af3cc0b4b473ff4R122

to:

highlights[currentPage]?.login

but the error states the login attribute is not defined on the type. Any idea where types are defined in this app? The API endpoint includes login

{
      "id": 237133,
      "user_id": 237133,
      "url": "github.com/open-sauced/insights/pull/1",
      "title": "My First PR!",
      "highlight": "\n    I made my first open source pull request!\n    \n    github.com/open-sauced/insights/pull/1",
      "pinned": false,
      "created_at": "2023-01-19 13:24:51.000000",
      "updated_at": "2023-01-19 13:24:51.000000",
      "deleted_at": "2023-01-19 13:24:51.000000",
      "shipped_at": "2023-01-19 13:24:51.000000",
      "full_name": "open-sauced/insights",
      "name": "Brian Douglas",
      "login": "bdougie"
    }

@bdougie
Copy link
Member Author

bdougie commented Jun 3, 2023

nvm, it is clearly defined here https://github.com/open-sauced/ai/blob/beta/src/pages/home.tsx#L21-L26

@github-actions
Copy link

github-actions bot commented Jun 3, 2023

馃帀 This issue has been resolved in version 1.4.0-beta.2 馃帀

The release is available on GitHub release

Your semantic-release bot 馃摝馃殌

@github-actions
Copy link

github-actions bot commented Jun 3, 2023

馃帀 This issue has been resolved in version 1.4.0 馃帀

The release is available on GitHub release

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants