Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec says name is required for Link Objects, but example does not have it set #648

Open
Simon-Laux opened this issue May 17, 2023 · 0 comments

Comments

@Simon-Laux
Copy link

this is basically the same thing as #647.

The example does not follow the spec. In the spec the name field is required.
spec: https://spec.open-rpc.org/#link-object
example: link-example-openrpc.json

"links": {
      "UserRepositories": {
        "description": "Get the repositories by owner.",
        "summary": "Get the repos by owner",
        "server":{
          "name": "Other Server Name",
          "description": "Use other server instead",
          "url": "http://localhost:9210"
        },
        "method": "get_repositories_by_owner",
        "params": {
          "username": "${result.username}"
        }
      },
      "UserRepository": {
        "method": "getRepository",
        "params": {
          "username": "${result.owner.username}",
          "slug": "${result.slug}"
        }
      },
      "RepositoryPullRequests": {
        "method": "getPullRequestsByRepository",
        "params": {
          "username": "${result.owner.username}",
          "slug": "${result.slug}"
        }
      },
      "PullRequestMerge": {
        "method": "mergePullRequest",
        "params": {
          "username": "${result.author.username}",
          "slug": "${result.repository.slug}",
          "pid": "${result.id}"
        }
      }
    },
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant