Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema ENUMS that would be helpful #754

Open
bdeadman opened this issue Oct 11, 2024 · 1 comment
Open

Schema ENUMS that would be helpful #754

bdeadman opened this issue Oct 11, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@bdeadman
Copy link
Collaborator

Addition Devices:

  • weighing
  • scoop (pre-calibrated volumetric scoops used to dispense solids)
  • stock_solution_with_evaporation (or similar, for describing adding solids in HTE as a soln, and then evaporating.)

Analysis Data Types:

  • Area Percent (we have area and we have percentage, but area percent means something specific and it is common in HTE data)
@bdeadman bdeadman added the enhancement New feature or request label Oct 11, 2024
@bdeadman bdeadman self-assigned this Oct 11, 2024
@connorcoley
Copy link
Collaborator

connorcoley commented Oct 11, 2024

Addition Devices

I think an addition device of a scoop makes a ton of sense. I'm not sure about how to denote the stock solution with evaporation (i.e., the most concise description) but I get the sentiment and need to capture that. It's more like it's a solution-phase addition to the vessel followed by a preparation step to evaporate. I would probably record it as a solution-phase addition where the device is whatever was used for the solution, then put the evaporation step in details for now. Would be good to discuss!

Area Percent

For this, I would use type AREA, use the percentage value, and indicate is_normalized = True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants