Skip to content

Test PR preview workflow using GitHub Actions #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 20 commits into from

Conversation

NPDebs
Copy link
Collaborator

@NPDebs NPDebs commented Nov 19, 2024

👍🎉 First of all, thanks for taking the time to contribute! 🎉👍

FOR CONTRIBUTOR

PR Type:

  • This PR adds a new blog post
  • This PR does something else (explain above)

Added a PR preview workflow using GitHub Actions

FOR REVIEWERS

Thanks for taking the time to review! ❤️

Here are the list of things to make sure of:

  • The website builds (a check will fail if not)
  • All images have been added within the Pull Request and they have Alt text
  • If there are paragraphs or text, the key messages are highlighted
  • All internal links (within OLS website) use the {% link path_to_file.md %} format
  • The preview corresponds to the changes described in the Pull Request
  • The code is tidy and passes the linting tests

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for ols-bebatut ready!

Name Link
🔨 Latest commit 994c862
🔍 Latest deploy log https://app.netlify.com/sites/ols-bebatut/deploys/67cea477eac2b000083a63df
😎 Deploy Preview https://deploy-preview-922--ols-bebatut.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yochannah yochannah self-assigned this Feb 7, 2025
@yochannah
Copy link
Member

@NPDebs am I right in thinking we could slose this PR if the Jekyll one is merged?

@NPDebs
Copy link
Collaborator Author

NPDebs commented Feb 7, 2025

@NPDebs am I right in thinking we could slose this PR if the Jekyll one is merged?

We can...when we merge the other and make sure all is in order. I'll take responsibility for doing that. 👍🏽

@yochannah yochannah assigned NPDebs and unassigned yochannah Feb 10, 2025
@yochannah
Copy link
Member

@NPDebs we can close?

@NPDebs
Copy link
Collaborator Author

NPDebs commented Apr 9, 2025

@NPDebs we can close?

I was rushing here to close with a comment - something along the lines of "Closed by #948, after months of peril and turmoil."

Wanna do the honours, Yo?

@yochannah yochannah closed this Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants