Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIS time converter #65

Open
joshserrin opened this issue May 15, 2019 · 4 comments
Open

DIS time converter #65

joshserrin opened this issue May 15, 2019 · 4 comments

Comments

@joshserrin
Copy link

We provide DisTime to convert System.currentimemillis to dis time but not a conversion back. Ideally, given a pdu time, get the millis since epoch equivalent. Does this library provide that or is anyone aware of the java code that successfully does the conversion?

@leif81
Copy link
Member

leif81 commented May 15, 2019

Hi @joshserrin , it sounds like it could be a useful addition to the DisTime class. Would you like to submit a pull request?

@joshserrin
Copy link
Author

I don't have an implementation right now but if I write one I'll submit a PR. I'm just curious if other have implemented this function already.

A better description of the function would be 'Given a pduTime, convert to the millis since the top of the hour (since pduTimes are only relative to the hour)'.

@a-keleher
Copy link

Suggesting the attachment as an augmentation to ClockTime. It could go in DisTime, but this is where I would have expected it.

ClockTime.java.txt

@leif81
Copy link
Member

leif81 commented Dec 22, 2023

@a-keleher sorry for the long delay. Would you be able to submit this as a pull request so that the proposed change can be reviewed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants