Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wireshark reports Entity State PDUs as malformed #11

Open
bamamarc opened this issue Sep 15, 2021 · 5 comments
Open

Wireshark reports Entity State PDUs as malformed #11

bamamarc opened this issue Sep 15, 2021 · 5 comments
Labels

Comments

@bamamarc
Copy link

bamamarc commented Sep 15, 2021

I am creating Entity State PDUs using in the following manner:

{code}
// Serialize PDU to a big-endian stream
DataOutputStream dataOutputStream = new DataOutputStream(Endian.Big);
Pdu.MarshalAutoLengthSet(dataOutputStream);
// Send bytes
broadcastClient.Send(dataOutputStream.ConvertToBytes())
{code}

Wireshark is reporting that the packets are malformed. I have attached Wireshark packet capture screen shot images. I did notice the Capabilities parameters do not appear in the screenshots. It appears that the MarshalAutoLengthSet is not computing the length properly (143 bytes vs 144 bytes).

Thank you.

SA08Malformed1
SA08Malformed2
SA08Malformed3

@leif81 leif81 added the bug label Oct 5, 2021
@leif81
Copy link
Member

leif81 commented Oct 5, 2021

Thankyou for the report @bamamarc
Are you able and interested in submitting a pull request with a fix?

@owenfunkhouser
Copy link

Has a fix been created for this? Otherwise, I will work to create a pull request for this bug as it is affecting a project that I am working.

@leif81
Copy link
Member

leif81 commented May 28, 2022

@owenfunkhouser I am not aware of a fix for this yet. If you are interested in submitting a PR yes please do. I'll provide a review and help with the merge.

@bamamarc
Copy link
Author

I never got around to fixing it as it did not have any negative effects on our models. I have left this position and no longer am working on simulations and have no access to the code. I did create a DLL that handles both DIS 6 and DIS 7 versions.

@Schreck425
Copy link

Sorry I don't now where else to ask this.

I'm using the pdu.ArticulationParameters[i].ParameterValue that doesn't seem to match up with wireshark. I've compared it with other programs too and they seem to agree with wireshark's value. Is there some kind of trick to convert this number in OpenDIS? I thought that was a 64 bit value but it comes out as a double on OpenDIS. Is the 32 other bits just maybe screwing up my numbers?

Wireshark dispalys numbers like -1.5 while I get a number more like -.19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants