Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate initiationType #821

Closed
jpmckinney opened this issue Mar 14, 2019 · 4 comments
Closed

Deprecate initiationType #821

jpmckinney opened this issue Mar 14, 2019 · 4 comments
Assignees
Labels
Schema: Fields Relating to adding or deprecating fields in the JSON Schema
Milestone

Comments

@jpmckinney
Copy link
Member

jpmckinney commented Mar 14, 2019

The current definition ("An open competitive bidding or tendering to form contracts") is overly restrictive; this definition can only be respected if tender/procurementMethod is 'open'.


More broadly, the design reason for the initiationType field is best described here: #111 (comment)

In other words (and from memory), this field exists because it was anticipated that the tender block would be inappropriate for some types of contracting processes. This field was added in order to indicate to data users that different features would be available within the data for such processes. For example, if initiationType were 'lottery', then data users would look for a lottery block instead of a tender block.

However, in practice, the tender field has been implemented according to its broad definition ("The activities undertaken in order to enter into a contract."), i.e. for initiation/solicitation in general. This seems like the right approach, instead of having a different block for each kind of contracting process, which makes data use harder. To my knowledge, implementers have not yet encountered contracting processes for which the tender block is wholly inappropriate (processes with multiple stages have issues, but the tender block is still appropriate for at least one stage).

A related issue might therefore be to re-assess the design approach behind the initiationType field more broadly. In the meantime, besides correcting the code, we might want to treat the field and codelist as 'legacy'.

cc @duncandewhurst

@jpmckinney jpmckinney added the Codelist: Closed Relating to a closed codelist label Mar 22, 2019
@jpmckinney jpmckinney added this to the 1.2 milestone Apr 2, 2019
@jpmckinney jpmckinney changed the title initiationType: Change definition of "tender" initiationType: Change definition of 'tender' Jul 17, 2020
@jpmckinney jpmckinney added the Semantics Relating to field and code descriptions label Jul 17, 2020
@JachymHercher
Copy link
Contributor

JachymHercher commented Nov 14, 2020

Since

To my knowledge, implementers have not yet encountered contracting processes for which the tender block is wholly inappropriate (processes with multiple stages have issues, but the tender block is still appropriate for at least one stage).

and since plans to deal with multiple stage procedures do not seem to involve initiationType, I think treating it as legacy / deprecating it sounds like a good appraoch.

(For a moment I thought whether it couldn't be used for some very different use cases, e.g. if you want OCDS to cover government asset sales, but even if yes, a new field would still probably be less confusing for that purpose.)

@jpmckinney jpmckinney changed the title initiationType: Change definition of 'tender' Deprecate initiationType Nov 16, 2020
@jpmckinney jpmckinney added Schema: Fields Relating to adding or deprecating fields in the JSON Schema and removed Codelist: Closed Relating to a closed codelist Semantics Relating to field and code descriptions labels Nov 16, 2020
@jpmckinney
Copy link
Member Author

jpmckinney commented Nov 16, 2020

I am happy to deprecate initiationType, as it has not been used for its designed purpose. OCDS for PPPs changes the mandatory code to 'ppp', but this serves no real purpose.

@duncandewhurst
Copy link
Contributor

I'm also happy to deprecate it.

OCDS for PPPs changes the mandatory code to alert data users to the different fields used in the profile (publicAuthority instead of buyer etc.) although the tender block is still present. Once open-contracting-extensions/public-private-partnerships#236 is done, that won't be an issue any more and data users can use the extensions array in the package metadata to determine what additional fields to expect.

@jpmckinney
Copy link
Member Author

Also, we should remove/replace all mentions of "initiation" in the documentation. Except for the codelist, all of these occur in non-normative text, so that change can be done in a 1.1 pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Schema: Fields Relating to adding or deprecating fields in the JSON Schema
Projects
Status: Done
Development

No branches or pull requests

4 participants