Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop sending FileError items to Kingfisher Process #1144

Open
yolile opened this issue Feb 10, 2025 · 2 comments
Open

Stop sending FileError items to Kingfisher Process #1144

yolile opened this issue Feb 10, 2025 · 2 comments
Assignees

Comments

@yolile
Copy link
Member

yolile commented Feb 10, 2025

open-contracting/kingfisher-process#366 (comment)

@yolile yolile self-assigned this Feb 10, 2025
@yolile
Copy link
Member Author

yolile commented Feb 10, 2025

I think our options are:

  1. As part of kingfisher_process_api2, stop sending FileErrors to Process, but instead log the error and return (I don't like this approach as it feels out of the scope of the extension)
  2. Create a new extension only to log FileErrors (fewer changes to the existing code and logic)
  3. Delete the FileError class and replace it with logging the error instead of yielding a FileError item (requires several changes to the code, I think)

@jpmckinney thoughts?

@jpmckinney
Copy link
Member

3 is probably the best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants