Skip to content

fix!: unwrap standard transfer handler and fix spiff handler #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fabianburth
Copy link
Contributor

@fabianburth fabianburth commented Jun 6, 2025

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #1500

@fabianburth fabianburth requested a review from a team as a code owner June 6, 2025 16:45
@github-actions github-actions bot added !BREAKING-CHANGE! Breaking change in API or ocm-cli or spec kind/bugfix Bug component/ocm-cli OCM Command Line Interface size/s Small labels Jun 6, 2025
@fabianburth fabianburth force-pushed the fix/omit-access-types branch from 436a7cd to 5f34226 Compare June 6, 2025 16:54
Comment on lines +181 to +183
if sub == nil {
return fmt.Errorf("cannot transfer component version %s/%s", o.ComponentVersion.GetName(), o.ComponentVersion.GetVersion())
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add an explanation on why we cannot transfer the cv?

@fabianburth fabianburth marked this pull request as draft June 7, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!BREAKING-CHANGE! Breaking change in API or ocm-cli or spec component/ocm-cli OCM Command Line Interface kind/bugfix Bug size/s Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different transfer behaviour when using ocm transfer ctf/component/? (with options)
2 participants