Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag in registration controller that sets leaseDurationSeconds for ManagedCluster #542

Open
dongbeiqing91 opened this issue Jun 26, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@dongbeiqing91
Copy link
Contributor

Describe the enhancement
Add a flag in registration controller that sets leaseDurationSeconds for ManagedCluster

@dongbeiqing91 dongbeiqing91 added the enhancement New feature or request label Jun 26, 2024
@qiujian16
Copy link
Member

it could be set in the managedCluster, what you mean is the defaultLeaseDurationSeconds set at the init time, right?

User can still change this afterwards

@dongbeiqing91
Copy link
Contributor Author

It's about how the release system deals with this.
If leaseDurationSeconds can be set by the registration controller, the release system only has to apply pure specs.
If it needs to be updated afterwards, an extra job is needed.
In Cloud world, the first method is preferred.

@qiujian16
Copy link
Member

so it can be regarded as a default leaseDurationSection for all managedcluster, right?

@dongbeiqing91
Copy link
Contributor Author

Yes I think so. But anyway, it's nice to have, not a must have.

Copy link

This issue is stale because it has been open for 120 days with no activity. After 14 days of inactivity, it will be closed. Remove the stable label to prevent this issue from being closed.

@github-actions github-actions bot added the Stale label Nov 16, 2024
@qiujian16 qiujian16 removed the Stale label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants