Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating conda-forge #1624

Open
joserezende opened this issue Oct 18, 2024 · 8 comments
Open

Updating conda-forge #1624

joserezende opened this issue Oct 18, 2024 · 8 comments

Comments

@joserezende
Copy link

The version available on anaconda is from more than a year ago, it would be possible to update conda-forge? Thanks for now.

@ProfLeao
Copy link

Watching

@MaxHalford
Copy link
Member

Hey there. Actually we were the ones who first put River on Anaconda. It's too bad the person who did that didn't follow up with the new versions.

@ProfLeao
Copy link

How unfortunate! I'll see what I can do about that.

@ProfLeao
Copy link

The conda-forge-admin gave me the error listed below.

conda-forge/river-feedstock#26 (comment)

As I'm not a developer of the package, I'd like to know if there's a problem with removing these restrictions and leaving them as:

requirements:
  host:
    - cython
    - numpy
    - setuptools
    - wheel
    - setuptools-rust
    - pip
  run:
    - numpy >=1.23.0,<2.0.0
    - scipy >=1.12.1,<2.0.0
    - pandas >=2.1.0,<3.0.0

@MaxHalford
Copy link
Member

Yes I think that should work @ProfLeao! Thank you very much for taking a look 🙏

@synapticarbors
Copy link

There are a number of issues currently:

  1. It looks like river does not support cython>=3. Pinning it to cython <3 fixes the first set of issues.
  2. Building the package complains with the following:
building 'efficient_rollingrocauc' extension
  creating /home/conda/feedstock_root/build_artifacts/river_1729434273621/work/build/temp.linux-x86_64-cpython-310/build/lib.linux-x86_64-cpython-312/river/metrics/efficient_rollingrocauc
  /home/conda/feedstock_root/build_artifacts/river_1729434273621/_build_env/bin/x86_64-conda-linux-gnu-c++ -fvisibility-inlines-hidden -fmessage-length=0 -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O2 -ffunction-sections -pipe -isystem /home/conda/feedstock_root/build_artifacts/river_1729434273621/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/include -fdebug-prefix-map=/home/conda/feedstock_root/build_artifacts/river_1729434273621/work=/usr/local/src/conda/river-0.21.2 -fdebug-prefix-map=/home/conda/feedstock_root/build_artifacts/river_1729434273621/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place=/usr/local/src/conda-prefix -DNDEBUG -D_FORTIFY_SOURCE=2 -O2 -isystem /home/conda/feedstock_root/build_artifacts/river_1729434273621/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/include -fPIC -DNPY_NO_DEPRECATED_API=NPY_1_7_API_VERSION -Ibuild/lib.linux-x86_64-cpython-312/river/metrics/efficient_rollingrocauc -I/home/conda/feedstock_root/build_artifacts/river_1729434273621/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.10/site-packages/numpy/core/include -I/home/conda/feedstock_root/build_artifacts/river_1729434273621/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/include/python3.10 -c build/lib.linux-x86_64-cpython-312/river/metrics/efficient_rollingrocauc/efficient_rollingrocauc.cpp -o /home/conda/feedstock_root/build_artifacts/river_1729434273621/work/build/temp.linux-x86_64-cpython-310/build/lib.linux-x86_64-cpython-312/river/metrics/efficient_rollingrocauc/efficient_rollingrocauc.o -std=c++11
  In file included from build/lib.linux-x86_64-cpython-312/river/metrics/efficient_rollingrocauc/efficient_rollingrocauc.cpp:1272:
  build/lib.linux-x86_64-cpython-312/river/metrics/efficient_rollingrocauc/cpp/RollingROCAUC.cpp:1:10: fatal error: RollingROCAUC.hpp: No such file or directory
      1 | #include "RollingROCAUC.hpp"
        |          ^~~~~~~~~~~~~~~~~~~

The file is in the source distribution, but something isn't configured properly, I believe on the river side of things.

@synapticarbors
Copy link

I'm currently trying to get 0.21.2 built in the following PR:
conda-forge/river-feedstock#28

@ProfLeao
Copy link

I'm currently trying to get 0.21.2 built in the following PR: conda-forge/river-feedstock#28

Have you made any progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants