-
-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBSTREAM: add "time" argument to the learn function #1472
Comments
I think this is a great idea! @Dennis1989 what do you think? |
@ShkarupaDC Hi! Sorry for getting this late to get back to you. Within the original paper, the authors have designed DBSTREAM with the Moreover, in data stream in general, we usually assume that data comes once at a time. As such, when samples arrive simultaneously, what we would usually do would be to consider them as other data points, coming one by one and in order. This might seem unreasonable, but to make DBSTREAM compatible with the design language of River in general, and to align with such philosophy, we decided to implement it this way. Hope that this answer clearly explains your concerns. |
Hi! I want to propose a new feature for DBSTREAM.
DBSTREAM uses a protected internal timer (
_time_stamp
) to measure the time between learning steps. There are 2 issues with this approach.if these arrivals are sequential (no other samples arrive in between). However, there can be a large difference from the business perspective.
I propose to add a
t
(time) argument to thelearn_one
function. Then, we can learn from samples using the samet
value if samples arrive simultaneously and supply time in any units to this function, adjusting thefading_factor
.The text was updated successfully, but these errors were encountered: