Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

yarn install fails with node v10.6.0 #2430

Closed
Muream opened this issue Jul 15, 2018 · 3 comments · Fixed by #2679 · May be fixed by #2601
Closed

yarn install fails with node v10.6.0 #2430

Muream opened this issue Jul 15, 2018 · 3 comments · Fixed by #2679 · May be fixed by #2601
Labels
insider

Comments

@Muream
Copy link
Contributor

Muream commented Jul 15, 2018

Oni Version: Master
Neovim Version (Linux only): 0.3.0
Operating System: Arch Linux

Issue:
I basically had this issue: facebook/create-react-app#4367
running yarn --ignore-engines install did the trick but it might be worth updating the upath version since
it seems the latest version doesn't have this problem.

Steps to reproduce:
Simply follow what the wiki says to build Oni with node v10.6.0
@oni-bot oni-bot bot added the insider label Jul 15, 2018
@Prior99
Copy link
Contributor

Prior99 commented Sep 28, 2018

This is due to the dependency upath not being the latest version. According to anodynos/upath#24, it needs to be upgraded in order to resolve this.

@Prior99 Prior99 mentioned this issue Oct 2, 2018
Open
@ghost ghost mentioned this issue Dec 14, 2018
Merged
@ghost
Copy link

ghost commented Dec 23, 2018 •
edited by ghost

Not fixed? On openSUSE Tumbleweed:

% git describe --tags --long
v0.3.7-beta2-37-gc7b11e46

% yarn install  
yarn install v1.12.3
[1/4] Resolving packages...
[2/4] Fetching packages...
error [email protected]: The engine "node" is incompatible with this module. Expected version ">=4 <=9". Got "10.13.0"

If run with --ignore-engines:

% yarn --ignore-engines install
yarn install v1.12.3
[1/4] Resolving packages...
[2/4] Fetching packages...
info [email protected]: The platform "linux" is incompatible with this module.
info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
info [email protected]: The platform "linux" is incompatible with this module.
info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
info [email protected]: The platform "linux" is incompatible with this module.
info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
info [email protected]: The platform "linux" is incompatible with this module.
info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
info [email protected]: The platform "linux" is incompatible with this module.
info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
warning " > [email protected]" has incorrect peer dependency "oni-types@^0.0.4".
warning " > [email protected]" has incorrect peer dependency "typescript@^2.5.3".
warning " > [email protected]" has unmet peer dependency "rimraf@^2.6.2".
warning " > [email protected]" has incorrect peer dependency "[email protected]".
warning " > [email protected]" has unmet peer dependency "babel-core@^6.26.3 || ^7.0.0-0".
warning " > [email protected]" has incorrect peer dependency "[email protected]".
warning " > [email protected]" has incorrect peer dependency "typescript@^2.5.2".
warning "typescript-plugin-styled-components > [email protected]" has incorrect peer dependency "typescript@^2.4.2".
[4/4] Building fresh packages...
⠁ 
⠁ 
[1/11] ⠂ font-manager
[1/11] ⠂ font-manager
[1/11] ⠂ font-manager
[1/11] ⠠ font-manager
[2/11] ⠠ keyboard-layout
[7/11] ⠠ bs-platform
success Saved lockfile.

% yarn run build               
yarn run v1.12.3
$ yarn run build:browser && yarn run build:webview_preload && yarn run build:main && yarn run build:plugins && yarn run build:cli
$ webpack --config browser/webpack.production.config.js
Hash: bceab875fb2cb19eaa54
Version: webpack 4.6.0
Time: 48595ms
Built at: 12/23/2018 10:54:40 AM
           Asset       Size  Chunks             Chunk Names
    13.bundle.js   2.44 KiB      13  [emitted]  
vendor.bundle.js    1.9 MiB       0  [emitted]  vendor
     2.bundle.js   1.06 KiB       2  [emitted]  
     3.bundle.js   1.28 KiB       3  [emitted]  
     4.bundle.js      4 KiB       4  [emitted]  
     5.bundle.js   4.27 KiB       5  [emitted]  
     6.bundle.js    2.7 KiB       6  [emitted]  
     7.bundle.js   3.13 KiB       7  [emitted]  
     8.bundle.js   11.9 KiB       8  [emitted]  
     9.bundle.js    6.3 KiB       9  [emitted]  
    10.bundle.js    365 KiB      10  [emitted]  
    11.bundle.js   10.9 KiB      11  [emitted]  
    12.bundle.js  996 bytes      12  [emitted]  
     1.bundle.js   92.5 KiB       1  [emitted]  
    14.bundle.js   1.01 KiB      14  [emitted]  
    15.bundle.js      2 KiB      15  [emitted]  
    16.bundle.js   2.84 KiB      16  [emitted]  
    17.bundle.js   4.28 KiB      17  [emitted]  
    18.bundle.js   1.05 KiB      18  [emitted]  
    19.bundle.js   31.8 KiB      19  [emitted]  
    20.bundle.js   1.14 KiB      20  [emitted]  
    21.bundle.js  556 bytes      21  [emitted]  
    22.bundle.js   1.76 KiB      22  [emitted]  
    23.bundle.js   34.1 KiB      23  [emitted]  
    24.bundle.js   17.5 KiB      24  [emitted]  
       bundle.js   86.4 KiB      25  [emitted]  main
Entrypoint main = bundle.js
  [4] external "fs" 42 bytes {25} [built]
  [6] external "electron" 42 bytes {25} [built]
 [20] ./browser/src/Utility.ts 6.92 KiB {25} [built]
 [39] ./browser/src/App.ts 15.7 KiB {25} [built]
 [58] ./browser/src/Services/CommandManager.ts 2.25 KiB {0} [built]
[158] ./browser/src/index.tsx 1 KiB {25} [built]
[159] multi ./browser/src/index.tsx 28 bytes {25} [built]
[211] ./browser/src/Plugins/PluginSidebarPane.tsx 6.37 KiB {4} [built]
[212] ./browser/src/Services/AutoClosingPairs.ts 7.41 KiB {7} [built]
[215] ./browser/src/CSS.ts 201 bytes {11} [built]
[216] ./browser/src/Services/Themes/ThemePicker.ts 1.9 KiB {12} [built]
[217] ./browser/src/Services/Terminal.ts 1.58 KiB {14} [built]
[218] ./browser/src/Services/BrowserWindowConfigurationSynchronizer.ts 2.13 KiB {18} [built]
[223] ./browser/src/Services/Debug.ts 1.68 KiB {20} [built]
[224] ./browser/src/Services/Configuration/ConfigurationCommands.ts 802 bytes {21} [built]
    + 1676 hidden modules
$ cd webview_preload && tsc -p tsconfig.json
$ cd main && tsc -p tsconfig.json
$ run-p build:plugin:*
$ cd vim/core/oni-plugin-git && yarn run build
$ cd vim/core/oni-plugin-typescript && yarn run build
$ cd extensions/oni-plugin-markdown-preview && yarn run build
$ cd extensions/oni-plugin-quickopen && yarn run build
warning package.json: No license field
warning package.json: No license field
warning package.json: No license field
$ rimraf lib && tsc
warning package.json: No license field
$ rimraf lib && tsc
$ rimraf lib && tsc
$ npm install && tsc
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN [email protected] No description
npm WARN [email protected] No repository field.
npm WARN [email protected] No license field.

added 6 packages from 6 contributors and audited 6 packages in 2.959s
found 0 vulnerabilities

src/index.tsx:132:60 - error TS2339: Property 'raw' does not exist on type 'SimpleGit'.

132             const raw = await this._git(this._projectRoot).raw(cmd)
                                                               ~~~

src/index.tsx:143:48 - error TS2339: Property 'reset' does not exist on type 'SimpleGit'.

143             await this._git(this._projectRoot).reset(flags)
                                                   ~~~~~

src/index.tsx:153:48 - error TS2339: Property 'reset' does not exist on type 'SimpleGit'.

153             await this._git(this._projectRoot).reset(["--soft", "HEAD^"])
                                                   ~~~~~

src/index.tsx:180:63 - error TS2339: Property 'commit' does not exist on type 'SimpleGit'.

180             const commit = await this._git(this._projectRoot).commit(message, files)
                                                                  ~~~~~~

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with signal "SIGTERM".
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with signal "SIGTERM".
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with signal "SIGTERM".
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
ERROR: "build:plugin:oni-plugin-git" exited with 1.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@saitonakamura
Copy link

saitonakamura commented Dec 28, 2018 •
edited

Not working for me also. Despite having ignore-engines in .yarnrc, yarn doesn't seem to peek this settings (maybe a windows issue). By the way, upath was updated to 1.0.5 where it doesn't have this issue. We can use yarn resolutions to fix it for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
insider
Projects
None yet
Milestone
No milestone
3 participants
@Prior99 @saitonakamura @Muream