Skip to content

Conversation

@turbolent
Copy link
Member

@turbolent turbolent commented Nov 6, 2025

Description

Automatically update to:

Summary by CodeRabbit

  • Chores
    • Updated multiple core dependencies to latest stable versions, including Ethereum client, Flow-related packages, Google Cloud KMS, and supporting libraries, for improved stability and compatibility.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 6, 2025

Walkthrough

This pull request updates Go module dependencies across the main and test modules to newer patch and minor versions. Changes include updates to Ethereum client (go-ethereum), Flow-related modules (cadence, flow-go, flow-go-sdk, flow-emulator, flow-core-contracts), Google Cloud KMS, VictoriaMetrics, snappy, and genproto APIs. No code logic or API changes are introduced.

Changes

Cohort / File(s) Summary
Go Module Dependency Updates
go.mod, tests/go.mod
Updated multiple direct and indirect dependencies to newer versions: go-ethereum (v1.16.4→v1.16.5), cadence (v1.8.1→v1.8.3), flow-go (snapshot→v0.43.3-0.20251029192457-d4f875155987), flow-go-sdk (v1.9.0→v1.9.2), flow-emulator (snapshot→v1.10.4 in tests), cloud.google.com/go/kms (v1.22.0→v1.23.1), fastcache (v1.12.2→v1.13.0), snappy (v0.0.5→v1.0.0), flow-core-contracts (v1.9.0→v1.9.1), genproto APIs/RPC, and various indirect modules. Removed glebarez/go-sqlite; added and reorganized indirect dependencies in tests/go.mod.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Verify compatibility across multiple interdependent Flow modules (cadence, flow-go, flow-go-sdk)
  • Check for any breaking changes in snappy v1.0.0 upgrade (significant version change)
  • Confirm removal of glebarez/go-sqlite does not impact test suite
  • Validate genproto and grpc version compatibility chain

Possibly related PRs

Suggested reviewers

  • zhangchiqing
  • m-Peter
  • janezpodhostnik
  • peterargue

Poem

🐰 Dependencies dance in the version ballet,
Patched and bumped in every way,
Flow and Ethereum take their bows,
Snappy's upgraded now—no how-to-hows! 📦✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title focuses on the Cadence update, which is part of the changeset but represents only one of multiple significant dependency updates across the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch auto-update-onflow-cadence-v1.8.3

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 638fe2e and 79b7ecb.

⛔ Files ignored due to path filters (2)
  • go.sum is excluded by !**/*.sum
  • tests/go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • go.mod (5 hunks)
  • tests/go.mod (6 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-01-29T17:20:28.143Z
Learnt from: m-Peter
Repo: onflow/flow-evm-gateway PR: 738
File: .github/workflows/ci.yml:19-19
Timestamp: 2025-01-29T17:20:28.143Z
Learning: Go 1.23 was released and is available for use in CI/CD pipelines and Docker images.

Applied to files:

  • tests/go.mod
📚 Learning: 2025-01-29T17:20:28.143Z
Learnt from: m-Peter
Repo: onflow/flow-evm-gateway PR: 738
File: .github/workflows/ci.yml:19-19
Timestamp: 2025-01-29T17:20:28.143Z
Learning: Go 1.23 is scheduled to be released on August 13, 2024, and should not be used in production before its official release.

Applied to files:

  • tests/go.mod
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Lint
  • GitHub Check: Test
🔇 Additional comments (7)
go.mod (3)

7-7: Dependency updates align with PR objectives.

The main Flow-related updates match the stated PR goals: cadence v1.8.3, flow-go-sdk v1.9.2, flow-go commit d4f875155987, plus ecosystem updates (Ethereum, KMS, VictoriaMetrics).

Also applies to: 13-15, 37-37, 43-43


92-92: Verify snappy v1.0.0 major version compatibility.

The snappy update represents a significant jump from v0.0.5 to v1.0.0 (major version bump). This may introduce breaking changes in the API or behavior. Ensure this version is compatible with how snappy is used throughout the codebase, particularly with indirect dependencies that may depend on it.


222-223: Genproto API pseudo-version updates applied.

The googleapis/api and googleapis/rpc pseudo-version updates are newer than previously pinned versions. These updates appear aligned with grpc infrastructure changes.

tests/go.mod (4)

6-6: Test module direct dependencies updated consistently with main go.mod.

The test module's direct dependencies mirror the main module's Flow ecosystem updates (cadence v1.8.3, flow-emulator v1.10.4, flow-go-sdk v1.9.2, flow-go pseudo-version).

Also applies to: 8-8, 10-10, 12-13


25-25: Indirect dependencies updated consistently.

Key indirect updates (KMS v1.23.1, fastcache v1.13.0, snappy v1.0.0, flow-core-contracts, genproto) align with go.mod changes.

Also applies to: 31-31, 90-90, 160-161, 250-251


252-252: Verify grpc version mismatch resolution.

tests/go.mod pins google.golang.org/grpc v1.76.0 (indirect, line 252), while go.mod requires v1.75.1 (line 28). This suggests the test environment resolves a newer grpc version via transitive dependencies (likely from updated Flow modules). Confirm this version mismatch is intentional and does not cause conflicts in the main build.


127-127: Expanded indirect dependencies from flow-emulator v1.10.4.

New indirect entries (kballard/go-shellquote, golang.org/x/{mod,tools} updates, lukechampine.com/uint128, modernc.org/*) appear to be transitive pulls from flow-emulator v1.10.4's test infrastructure. Confirm these are expected and review whether any introduce unintended build-time or test-time tooling.

Also applies to: 237-237, 244-244, 259-268


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@m-Peter m-Peter self-assigned this Nov 7, 2025
Copy link
Collaborator

@m-Peter m-Peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@m-Peter m-Peter merged commit b002906 into main Nov 7, 2025
2 checks passed
@m-Peter m-Peter deleted the auto-update-onflow-cadence-v1.8.3 branch November 7, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants