Add engine type to startup logs #597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezpodhostnik
requested review from
m-Peter and
peterargue
as code owners
Contributor
WalkthroughThe pull request introduces changes in the Changes
Sequence Diagram(s)sequenceDiagram
participant A as StartEventIngestion
participant B as StartTraceDownloader
participant C as StartEngine
A->>C: Call StartEngine
B->>C: Call StartEngine
C->>C: Initialize engine
C->>C: Log startup duration
C-->>A: Return
C-->>B: Return
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
m-Peter
reviewed
Sep 30, 2024
| logger zerolog.Logger, | ||
| ) { | ||
| logger.Info().Msg("starting engine") | ||
| l := logger.With().Type("engine", engine).Logger() |
m-Peter
reviewed
Sep 30, 2024
| <-engine.Ready() | ||
| logger.Info().Msg("engine started successfully") | ||
| l.Info(). | ||
| Dur("duration", time.Since(start)). |
Collaborator
|
@janezpodhostnik I think you also need to run: $ cd tests/
$ go mod tidy |
janezpodhostnik
force-pushed
the
janez/add-engine-name-to-starup
branch
from
38269dd to
b89212c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just cleaning up a bit as I get familiar with the codebase.
github.com/rs/zerolog v1.33.0is required forlogger.With().Type("engine", engine).For contributor use:
masterbranchFiles changedin the Github PR explorerSummary by CodeRabbit
zerologdependency to the latest version for improved logging capabilities.