Merge pull request #3977 from onflow/bastian/refactor-builtin-functions

turbolent · web-flow · commit 1a839f18f6bd · 2025-05-28T09:09:12.000-07:00
Refactor string value parsers and big-endian bytes converters to be reusable in compiler/VM
diff --git a/interpreter/interpreter.go b/interpreter/interpreter.go
diff --git a/interpreter/value_fix64.go b/interpreter/value_fix64.go
@@ -75,7 +75,7 @@ func NewUnmeteredFix64Value(integer int64) Fix64Value {
 	return Fix64Value(integer)
 }
 
-func NewFix64ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) Fix64Value {
+func NewFix64ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) Value {
 	return NewFix64Value(
 		gauge,
 		func() int64 {
diff --git a/interpreter/value_int128.go b/interpreter/value_int128.go
@@ -96,7 +96,7 @@ func NewUnmeteredInt128ValueFromBigInt(value *big.Int) Int128Value {
 	}
 }
 
-func NewInt128ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) Int128Value {
+func NewInt128ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) Value {
 	return NewInt128ValueFromBigInt(
 		gauge,
 		func() *big.Int {
diff --git a/interpreter/value_int16.go b/interpreter/value_int16.go
@@ -51,7 +51,7 @@ func NewUnmeteredInt16Value(value int16) Int16Value {
 	return Int16Value(value)
 }
 
-func NewInt16ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) Int16Value {
+func NewInt16ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) Value {
 	return NewInt16Value(
 		gauge,
 		func() int16 {
diff --git a/interpreter/value_int8.go b/interpreter/value_int8.go
@@ -50,7 +50,7 @@ func NewUnmeteredInt8Value(value int8) Int8Value {
 	return Int8Value(value)
 }
 
-func NewInt8ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) Int8Value {
+func NewInt8ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) Value {
 	return NewInt8Value(
 		gauge,
 		func() int8 {
diff --git a/interpreter/value_uint16.go b/interpreter/value_uint16.go
@@ -58,7 +58,7 @@ func NewUnmeteredUInt16Value(value uint16) UInt16Value {
 	return UInt16Value(value)
 }
 
-func NewUInt16ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) UInt16Value {
+func NewUInt16ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) Value {
 	return NewUInt16Value(
 		gauge,
 		func() uint16 {
diff --git a/interpreter/value_uint32.go b/interpreter/value_uint32.go
@@ -49,7 +49,7 @@ func NewUnmeteredUInt32Value(value uint32) UInt32Value {
 	return UInt32Value(value)
 }
 
-func NewUInt32ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) UInt32Value {
+func NewUInt32ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) Value {
 	return NewUInt32Value(
 		gauge,
 		func() uint32 {
diff --git a/interpreter/value_uint8.go b/interpreter/value_uint8.go
@@ -58,7 +58,7 @@ func NewUnmeteredUInt8Value(value uint8) UInt8Value {
 	return UInt8Value(value)
 }
 
-func NewUInt8ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) UInt8Value {
+func NewUInt8ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) Value {
 	return NewUInt8Value(
 		gauge,
 		func() uint8 {
diff --git a/interpreter/value_word8.go b/interpreter/value_word8.go
@@ -58,7 +58,7 @@ func NewUnmeteredWord8Value(value uint8) Word8Value {
 	return Word8Value(value)
 }
 
-func NewWord8ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) Word8Value {
+func NewWord8ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) Value {
 	return NewWord8Value(
 		gauge,
 		func() uint8 {

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ func NewUnmeteredFix64Value(integer int64) Fix64Value {`
`75`	`75`	`return Fix64Value(integer)`
`76`	`76`	`}`
`77`	`77`
`78`		`-func NewFix64ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) Fix64Value {`
	`78`	`+func NewFix64ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) Value {`
`79`	`79`	`return NewFix64Value(`
`80`	`80`	`gauge,`
`81`	`81`	`func() int64 {`
Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ func NewUnmeteredInt128ValueFromBigInt(value *big.Int) Int128Value {`
`96`	`96`	`}`
`97`	`97`	`}`
`98`	`98`
`99`		`-func NewInt128ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) Int128Value {`
	`99`	`+func NewInt128ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) Value {`
`100`	`100`	`return NewInt128ValueFromBigInt(`
`101`	`101`	`gauge,`
`102`	`102`	`func() *big.Int {`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ func NewUnmeteredInt16Value(value int16) Int16Value {`
`51`	`51`	`return Int16Value(value)`
`52`	`52`	`}`
`53`	`53`
`54`		`-func NewInt16ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) Int16Value {`
	`54`	`+func NewInt16ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) Value {`
`55`	`55`	`return NewInt16Value(`
`56`	`56`	`gauge,`
`57`	`57`	`func() int16 {`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ func NewUnmeteredInt8Value(value int8) Int8Value {`
`50`	`50`	`return Int8Value(value)`
`51`	`51`	`}`
`52`	`52`
`53`		`-func NewInt8ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) Int8Value {`
	`53`	`+func NewInt8ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) Value {`
`54`	`54`	`return NewInt8Value(`
`55`	`55`	`gauge,`
`56`	`56`	`func() int8 {`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ func NewUnmeteredUInt16Value(value uint16) UInt16Value {`
`58`	`58`	`return UInt16Value(value)`
`59`	`59`	`}`
`60`	`60`
`61`		`-func NewUInt16ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) UInt16Value {`
	`61`	`+func NewUInt16ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) Value {`
`62`	`62`	`return NewUInt16Value(`
`63`	`63`	`gauge,`
`64`	`64`	`func() uint16 {`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ func NewUnmeteredUInt32Value(value uint32) UInt32Value {`
`49`	`49`	`return UInt32Value(value)`
`50`	`50`	`}`
`51`	`51`
`52`		`-func NewUInt32ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) UInt32Value {`
	`52`	`+func NewUInt32ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) Value {`
`53`	`53`	`return NewUInt32Value(`
`54`	`54`	`gauge,`
`55`	`55`	`func() uint32 {`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ func NewUnmeteredWord8Value(value uint8) Word8Value {`
`58`	`58`	`return Word8Value(value)`
`59`	`59`	`}`
`60`	`60`
`61`		`-func NewWord8ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) Word8Value {`
	`61`	`+func NewWord8ValueFromBigEndianBytes(gauge common.MemoryGauge, b []byte) Value {`
`62`	`62`	`return NewWord8Value(`
`63`	`63`	`gauge,`
`64`	`64`	`func() uint8 {`