614 - feat: receive page RN bridge and entry point #2048
Conversation
|
⏳ Analyzing changes in this PR... ⏳ This might take a few minutes, please wait 📥 CommitsAnalyzing changes from base (
📁 Files being considered (3)🔄 app/src/main/java/com/flowfoundation/wallet/page/token/detail/presenter/TokenDetailPresenter.kt (1 hunk) autogenerated by presubmit.ai |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- af49813: feat: receive page RN bridge and entry point
Files Processed (3)
- app/src/main/java/com/flowfoundation/wallet/page/token/detail/presenter/TokenDetailPresenter.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/reactnative/ReactNativeActivity.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/reactnative/bridge/NativeFRWBridge.kt (1 hunk)
Actionable Comments (0)
Skipped Comments (3)
-
app/src/main/java/com/flowfoundation/wallet/reactnative/bridge/NativeFRWBridge.kt [196-201]
enhancement: "QR code dimensions are hardcoded"
-
app/src/main/java/com/flowfoundation/wallet/reactnative/bridge/NativeFRWBridge.kt [245-247]
best practice: "Missing cache cleanup mechanism"
-
app/src/main/java/com/flowfoundation/wallet/reactnative/bridge/NativeFRWBridge.kt [206-206]
enhancement: "Suboptimal bitmap configuration for QR code"
app/src/main/java/com/flowfoundation/wallet/reactnative/bridge/NativeFRWBridge.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/flowfoundation/wallet/reactnative/ReactNativeActivity.kt
Outdated
Show resolved
Hide resolved
…receive-page-bridge
| val network = chainNetWorkString() | ||
|
|
||
| // Reuse existing launch method with "Receive" as the initialRoute | ||
| launch(context, null, address, network, "Receive") |
There was a problem hiding this comment.
I think we can just add Receive into RNBridge.ScreenType, instead of use hard code string in here.
And then we don't need create a new launchReceive method.
We can simply reuse fun launch(context: Context, screenType: RNBridge.ScreenType?)
| val routeName = getRouteName(it, null) | ||
|
|
||
| // Use explicit initialRoute if provided, otherwise determine from screenType | ||
| val routeName = initialRoute ?: screenType?.let { |
There was a problem hiding this comment.
each ScreenType should have screenName value as initialRoute.
Related Issue
Closes #???
Summary of Changes
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)