-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One v1.1.407-v1.1.410 fails to build when importing expo-image, but the error indicates it may affect other packages #444
Comments
@zetavg another good issue since we know the version it likely breaks |
Seems to work for me here: |
@natew did you try a production build? I just tried One Edit: I just noticed I've been doing my testing with expo-image 2.x. I'll try 1.x and see if that changes anything. But, 2.x was previously working. |
Downgraded So for now, you can probably close this. Just note, when Expo does sort out 2.x, we might need to revisit this. |
Spent a couple of days testing All that to say, I think it's worth getting |
Updated one, and it seems this is resolved. Interesting enough, when I build Storybook using Vite with the One plugin, I still get the error I was getting. So whatever fixed it lives in the One cli maybe and not the One Vite plugin? I was thinking maybe a Vite 6.x update fixed it, but when I do Regardless, things still feel a little fragile, but I'm closing this issue since Expo Image 2.x now works with One. |
This is the error I see
Reproduce the issue
npm i --force
npm run build:web
npm run serve
As far as I can tell, this issue started in
v1.1.407
The text was updated successfully, but these errors were encountered: