Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One v1.1.407-v1.1.410 fails to build when importing expo-image, but the error indicates it may affect other packages #444

Closed
christianjuth opened this issue Jan 24, 2025 · 6 comments

Comments

@christianjuth
Copy link
Contributor

This is the error I see

Image Image

Reproduce the issue

  1. Clone the reproduction repo
  2. npm i --force
  3. npm run build:web
  4. npm run serve
  5. You should see a while screen and there should be an error in the browser console

As far as I can tell, this issue started in v1.1.407

@natew
Copy link
Collaborator

natew commented Jan 24, 2025

@zetavg another good issue since we know the version it likely breaks

@natew
Copy link
Collaborator

natew commented Jan 25, 2025

Seems to work for me here:

#450

@christianjuth
Copy link
Contributor Author

christianjuth commented Jan 25, 2025

@natew did you try a production build? I just tried One 1.1.411 and it works in dev but not with a production build of web.

Edit: I just noticed I've been doing my testing with expo-image 2.x. I'll try 1.x and see if that changes anything. But, 2.x was previously working.

@christianjuth
Copy link
Contributor Author

Downgraded expo-image to 1.x. I actually did it because 2.x seems to have some serious performance issues. When combined with FlashList and not that many items, it was adding (very unscientifically measured) 1+ seconds to my render time.

So for now, you can probably close this. Just note, when Expo does sort out 2.x, we might need to revisit this.

@christianjuth
Copy link
Contributor Author

Spent a couple of days testing expo-image 1.x. It definitely works, but it looks like Expo recommends 2.x for SDK-52. I've had some performance issues with 2.x, but it seems much better at handling Flash List's recycling (seeing previous images not updating as it recycles).

All that to say, I think it's worth getting 2.x working.

@christianjuth
Copy link
Contributor Author

christianjuth commented Feb 5, 2025

Updated one, and it seems this is resolved. Interesting enough, when I build Storybook using Vite with the One plugin, I still get the error I was getting. So whatever fixed it lives in the One cli maybe and not the One Vite plugin?

I was thinking maybe a Vite 6.x update fixed it, but when I do yarn why vite it seems like my entire repo is using the same Vite version. So I'm not sure why Storybook would still be getting the error.

Regardless, things still feel a little fragile, but I'm closing this issue since Expo Image 2.x now works with One.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants