-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for including oneCCL in a CMake mono build #83
Comments
Hello @sogartar, we'd like to get your case, is it possible for you to show how and which project you include oneccl to reproduce this issue? |
This is more of a feature request. oneCCL/tests/functional/CMakeLists.txt Line 65 in 9e66a9e
It technically has a superbuild. It should be something like
I also see there are things like
which is not the proper way to do it in CMake >= 3.0. You should use targets wherever possible and let the target provide its include directories and link libraries.
|
It would be nice to be able to include oneCCL inside another build directly.
This entails that all CMake configuration arguments should be prefixed by something like
ONECCL_
to avoid name conflicts.Also all targets should be prefixed. E.g.
oneccl::
.Another thing is to allow for all dependencies like googletest to be excludable from the build an provided externally. They may be defined somewhere else in the super build. E.g.
ONECCL_GOOGLE_TEST_EXTERNAL=ON
.The text was updated successfully, but these errors were encountered: