Properly escape interpolation-like strings in resolved configs #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
I think this needs tests to show what it's actually doing and to ensure it does not break in the future. |
Oh yes (see point 1 above)
I need to think about it a bit more, but I don't believe this is an issue. Will keep it in mind though. |
|
Hey I noticed a breaking change with this. See full description of it here: #1112 (comment) |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1112
Fixes #1081
This is a draft PR for several reasons:
to_container()andto_object()needs to be looked at (see Escaped resolver modifying_root_doesn't work #1120)Note that this is a breaking change, but it can be argued that the previous behavior was a bug (all tests pass).