Skip to content

Commit 4dc59e7

Browse files
authored
Merge pull request finos#789 from finos/dev
Merge dev into main
2 parents a43ae32 + ce675d5 commit 4dc59e7

File tree

10 files changed

+106
-16
lines changed

10 files changed

+106
-16
lines changed

.github/workflows/publish-docker.yml

Lines changed: 64 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
1+
name: Publish Docker image
2+
3+
on:
4+
workflow_dispatch: {}
5+
push:
6+
branches:
7+
- 'main'
8+
- 'dev'
9+
paths:
10+
- 'code/src/**'
11+
- 'code/package.json'
12+
- 'code/Dockerfile'
13+
- '.github/workflows/publish-docker.yml'
14+
15+
jobs:
16+
docker-scan:
17+
name: ${{ github.event.repository.name }}-docker-scan
18+
runs-on: ubuntu-latest
19+
steps:
20+
- uses: actions/checkout@v4
21+
- uses: docker-practice/actions-setup-docker@321477a1e481dd60b05f9b489cf4b9be467aa15c
22+
- name: Build
23+
run: docker build -f Dockerfile -t user/app:latest .
24+
working-directory: code
25+
#- name: Scan for vulnerabilities
26+
# uses: crazy-max/ghaction-container-scan@dfa7e54dc32045120f06d0bc8d7724860f5db0ad
27+
# with:
28+
# image: user/app:latest
29+
# severity_threshold: HIGH
30+
push-to-registry:
31+
name: Push Docker image to Docker Hub
32+
needs: docker-scan
33+
runs-on: ubuntu-latest
34+
# save forks from having issue trying to publish to Docker
35+
# without the correct credentials
36+
if: github.repository_owner == 'finos'
37+
outputs:
38+
digest: ${{ steps.build_publish.outputs.digest }}
39+
steps:
40+
- name: Check out the repo
41+
uses: actions/checkout@v4
42+
43+
- name: Log in to Docker Hub
44+
uses: docker/[email protected]
45+
with:
46+
username: finos
47+
password: ${{ secrets.DOCKER_PASSWORD }}
48+
49+
- name: Extract metadata (tags, labels) for Docker
50+
id: meta
51+
uses: docker/[email protected]
52+
with:
53+
images: finos/a11y-theme-builder
54+
tags: |
55+
type=ref,event=branch
56+
type=sha
57+
- name: Build and push Docker image
58+
id: build_publish
59+
uses: docker/[email protected]
60+
with:
61+
context: code
62+
push: true
63+
tags: ${{ steps.meta.outputs.tags }}
64+
labels: ${{ steps.meta.outputs.labels }}

.github/workflows/security.yml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,3 +52,16 @@ jobs:
5252
with:
5353
name: Depcheck report
5454
path: ${{ github.workspace }}/${{ matrix.module-folder }}-reports
55+
docker-scan:
56+
name: ${{ github.event.repository.name }}-docker-scan
57+
runs-on: ubuntu-latest
58+
steps:
59+
- uses: actions/checkout@v3
60+
- uses: docker-practice/actions-setup-docker@321477a1e481dd60b05f9b489cf4b9be467aa15c
61+
- name: Build
62+
run: docker build -f Dockerfile -t user/app:latest .
63+
working-directory: code
64+
- name: Scan for vulnerabilities
65+
uses: crazy-max/ghaction-container-scan@dfa7e54dc32045120f06d0bc8d7724860f5db0ad
66+
with:
67+
image: user/app:latest

CONTRIBUTE.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,10 @@ This section includes ways to get started with your open source project. Include
5555
Participating in our project community spans a variety of activities:
5656

5757
* Reporting bugs and enhancements requests
58-
* Contributing bug/feature solutions
58+
* Contributing bug/feature solutions and ideas for community content (see issues tagged with the 'community' tag for examples)
59+
* Joining Community Collaboration Space calls, held every other week at 11am ET (details on the [FINOS Calendar](https://www.finos.org/calendar))
60+
* Speaking at conferences and meetups to build awareness and community
61+
* Participating in Collaboration Summits
5962
* [Improving documentation](https://finos.github.io/a11y-theme-builder/)
6063
* [Identifying and tracking new use cases](https://finos.github.io/a11y-theme-builder/contribute)
6164
* Create an example of the project in real world by building something or showing what others have built.

code/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:18.18-bookworm-slim
1+
FROM node:18.19-bookworm-slim
22
RUN node -v
33
# Copy source
44
RUN mkdir $HOME/code

code/package-lock.json

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

code/src/ui/src/App.css

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
.html,body {
33
margin: 0;
44
padding: 0;
5+
overflow: hidden;
56
}
67

78
.top40 {
@@ -47,7 +48,7 @@ p a:hover {
4748
display: flex;
4849
border-radius: 16px;
4950
gap: 16px;
50-
background: "white";
51+
background: white;
5152
border: 1px solid rgba(0,0,0,.15);
5253
min-height: 24px;
5354
}
@@ -90,14 +91,14 @@ p a:hover {
9091
height: 24px;
9192
margin: 10px;
9293
float: left;
93-
border: 1px solid gray;
94+
border: 1px solid rgb(128, 128, 128); /*replaced deprecated gray with rgb equivalent*/
9495
}
9596

9697
.input-1 {
9798
width: 100%;
9899
height: 30px;
99100
font-size: var(--baseFont);
100-
margin: 8px 0px;
101+
margin: 8px 0;
101102
}
102103

103104
.darkmode .background, .darkmode.background {

code/src/ui/src/components/CreateColorTheme.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ export const CreateColorTheme: React.FC<Props> = ({atom, handleDefaultThemeIniti
154154
</div>
155155
<div className="formRow">
156156
<div className="subtitle1">Button Color</div>
157-
<div className="small">Note: The "To Color" will be limited to those colors with the same "On Color" or text color to make sure the gradiemt meets WCAG 2.1 AA contrast guidelines.</div>
157+
<div className="small">Note: Buttons limited to colors with a contrast against your primary and secondary backgrounds of 3.1: 1 to meet WCAG 2.1 AA Guidelines.</div>
158158
<div className="form-columns top16">
159159
<ColorSelect value={_colorTheme.button} label="Color:"></ColorSelect>
160160
</div>

code/src/ui/src/mui-a11y-tb/themes/TB.css

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -400,6 +400,7 @@
400400
--button-shadow: var(--elevation-1);
401401
--sm-button-height: 4;
402402
--sm-button-padding: 2;
403+
--mobile-button-radius: calc(calc( calc(var(--button-radius) * var(--radius-1)) / calc(var(--button-height) * var(--spacing-1)) ) * var(--mobile-min-target));
403404
/* Chips */
404405
--chip-minwidth: 80px;
405406
--chip-height: 5;
@@ -2551,8 +2552,8 @@
25512552
}
25522553

25532554
[data-background="primary"] {
2554-
--background: var(--primary-alt-background);
2555-
--alt-background: var(--primary-background);
2555+
--background: var(--primary-background);
2556+
--alt-background: var(--primary-alt-background);
25562557
--on-background: var(--primary-on-background);
25572558
/* Button */
25582559
--button: var(--primary-button);

code/src/ui/src/mui-a11y-tb/themes/Theme.css

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1723,6 +1723,9 @@ button.MuiPaginationItem-root:hover {
17231723
position: relative;
17241724
box-shadow: var(--sliderhandle-shadow);
17251725
}
1726+
.MuiSwitch-root:hover .MuiSwitch-switchBase:hover {
1727+
box-shadow: none;
1728+
}
17261729
.MuiSwitch-root .MuiSwitch-switchBase .MuiSwitch-thumb::after {
17271730
position: absolute;
17281731
pointer-events: none;
@@ -1795,6 +1798,7 @@ button.MuiPaginationItem-root:hover {
17951798
height: var(--min-target) !important;
17961799
width: var(--min-target) !important;
17971800
background: transparent !important;
1801+
box-shadow: none !important;
17981802
}
17991803
.MuiSlider-root .MuiSlider-thumb::before {
18001804
height: calc( var(--sliderhandleHeight) * var(--spacing-1) );
@@ -1823,6 +1827,8 @@ button.MuiPaginationItem-root:hover {
18231827
box-shadow: none !important;
18241828
}
18251829

1830+
1831+
18261832
/* popovers */
18271833
.MuiPopover-paper {
18281834
border-radius: calc(var(--popoverRadius) * var(--radius-1)) !important;
@@ -1937,6 +1943,9 @@ button.MuiPaginationItem-root:hover {
19371943
bottom: calc(0px - calc(var(--focusBorder) + 2px));
19381944
opacity: 1;
19391945
}
1946+
.MuiSwitch-switchBase:hover {
1947+
background-color: transparent !important;
1948+
}
19401949
/* icons */
19411950
.icon-body {
19421951
display: flex;

code/src/ui/src/mui-a11y-tb/themes/Theme.jsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -942,7 +942,6 @@ try {
942942
height: "calc(var(--sliderhandleHeight) * var(--spacing-1))",
943943
width: "calc(var(--sliderhandleHeight) * var(--spacing-1) )",
944944
borderRadius: "calc(var(--sliderhandleRadius) * var(--radius-1))",
945-
boxShadow: "var(--sliderhandle-shadow)",
946945
backgroundColor: "var(--button)",
947946
position: "absolute",
948947
top: "50%",
@@ -1033,7 +1032,7 @@ try {
10331032
minHeight: "calc( calc( var(--chip-height) * var(--spacing-1) ) - calc( var(--border-1) * var(--button-border) * 2 ))",
10341033
},
10351034
"&:hover::after": {
1036-
opacity: "var(--button-half)",
1035+
opacity: ".5",
10371036
top: "calc(((var(--min-target) - (var(--spacing-1) * var(--chip-height)))/2) - 3px)",
10381037
bottom: "calc(((var(--min-target) - (var(--spacing-1) * var(--chip-height)))/2) - 3px)",
10391038
left: "calc(-1px - calc(var(--border-1) * 2))",

0 commit comments

Comments
 (0)