Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure move scripts on dundeeomero #351

Open
pwalczysko opened this issue Jun 16, 2022 · 7 comments
Open

Figure move scripts on dundeeomero #351

pwalczysko opened this issue Jun 16, 2022 · 7 comments

Comments

@pwalczysko
Copy link
Member

pwalczysko commented Jun 16, 2022

In preparation of the workshop next week, noting that the scripts mentioned in https://omero-guides.readthedocs.io/en/latest/figure/docs/omero_figure_move.html#setup are not on dundeeomero server (nightshade).

What would be the correct course of action to get them there ?

cc @sbesson @will-moore @jburel

@sbesson
Copy link
Member

sbesson commented Jun 16, 2022

Announce a short server donwtime and update the playbook to deploy the scripts?
Obviously, as these scripts are being deployed to an increasing number of locations, this raises the question of whether they should be centralized and managed at the omero-scripts level

@jburel
Copy link
Member

jburel commented Jun 16, 2022

historically we have installed the scripts that are available under https://github.com/ome/omero-scripts and not from other repos. We need to review how we manage that

@will-moore
Copy link
Member

But we do install https://github.com/ome/omero-figure/blob/master/omero_figure/scripts/omero/figure_scripts/Figure_To_Pdf.py
as part of the figure install. Should these scripts live there?

@pwalczysko
Copy link
Member Author

pwalczysko commented Jun 16, 2022

Status quo at dundeeomero
Screenshot 2022-06-16 at 10 47 05
The https://github.com/ome/omero-scripts/tree/develop/omero/figure_scripts looks a bit different.
Yes, maybe this is a good time to unify the tactics here.

Also note that the scripts mentioned in the description of the issue are in omero-guide-figure https://github.com/ome/omero-guide-figure/tree/master/scripts

@jburel
Copy link
Member

jburel commented Jun 16, 2022

@will-moore The strategy for figure_to_pdf needs to be reviewed too since it comes also with dependencies (which recently created issue e.g. reportlab)

@jburel
Copy link
Member

jburel commented Jun 16, 2022

being under ome/scripts means that they are included in an openmicroscopy installation

@pwalczysko
Copy link
Member Author

deployed on ome-dundeeomero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants