Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlitzGateway: Support linking annotations to other annotations #433

Open
DavidStirling opened this issue Nov 4, 2024 · 1 comment
Open

Comments

@DavidStirling
Copy link
Contributor

A user came across this issue when trying to programatically create TagAnnotations linked under a parent TagSet.

Currently the linkAnnotation function on the Blitz wrapper classes uses the OMERO_CLASS class variable to construct the link object name. Since Annotation wrapper subclasses do not define this variable the function errors out searching for NoneAnnotationLink.

It looks like setting OMERO_CLASS = "Annotation" would fix this particular scenario (we need an AnnotationAnnotationLink), but it's not clear to me if this would cause problems with other functionality in the wrapper.

@will-moore
Copy link
Member

It makes sense that linkAnnotation() should work to create AnnotationAnnotationLinks.

Just searching for OMERO_CLASS finds this code that would need checking/updating:
https://github.com/ome/omero-py/blob/master/src/omero/gateway/__init__.py#L3421

I seem to remember the Parent-Child direction of links in TagSet->Tag was not intuitive, but I may have this wrong.
Is it tagset.linkAnnotation(tag) or would it be tag.linkAnnotation(tagset)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants