Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export script version check #556

Open
will-moore opened this issue Apr 26, 2024 · 1 comment · May be fixed by #612
Open

Export script version check #556

will-moore opened this issue Apr 26, 2024 · 1 comment · May be fixed by #612

Comments

@will-moore
Copy link
Member

As reported by @knabar and from our own experience, it's very easy for users (admins) to forget to update the script on the server to match the currently-installed version of the web app.

This can lead to unexplained errors or missing features when exporting figures.

Unfortunately the OMERO scripts API doesn't provide a way to get the version of an installed script.

However, it is possible to use the OMERO API to load the script text itself.
One option could be:

  • include the release version of figure within the export script in some way that can be easily parsed from the file.
  • this can be updated automatically with bump2version on release
  • In the omero_figure views.py or utils.py we could add a def check_script_version(conn) that would load the first part of the script and parse out the version and compare it to the current release version.
  • This function could be re-used by other tools if needed e.g. pathviewer
@will-moore
Copy link
Member Author

Recent example of script wrong version causing issues: #608

@will-moore will-moore linked a pull request Jan 29, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant