You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not sure if this is a bug or an intended change, and whether I should be using a different method. I wanted to generate a coverage report using verilator_coverage, so I added a post_run hook to run the command and generate the report, but the hook is never executed.
Looking at the code, I see that the hook is correctly added to the command chain in Edaflow's __init__ method. However, the run implementation in the Sim flow ignores the command chain and only executes the tool command.
I believe the run method in Edaflow shouldn’t be empty. Instead, it should execute the pre_run, run, and post_run commands. Each subclass of Edaflow should provide its own run command, but leaving the responsibility of executing the hooks to individual flow implementations is too error-prone.
I'm willing to provide a fix if this is indeed an issue, but I’d like to discuss the best way to implement it first.
The text was updated successfully, but these errors were encountered:
It might very well be broken. I recently fixed pre_build scripts not being run properly (e438f9f) but I haven't had time to check the run scripts. If you have a solution in mind, feel free to come up with a proposal or an implementation.
I'm not sure if this is a bug or an intended change, and whether I should be using a different method. I wanted to generate a coverage report using verilator_coverage, so I added a post_run hook to run the command and generate the report, but the hook is never executed.
Looking at the code, I see that the hook is correctly added to the command chain in Edaflow's
__init__
method. However, the run implementation in theSim
flow ignores the command chain and only executes the tool command.I believe the run method in Edaflow shouldn’t be empty. Instead, it should execute the pre_run, run, and post_run commands. Each subclass of Edaflow should provide its own run command, but leaving the responsibility of executing the hooks to individual flow implementations is too error-prone.
I'm willing to provide a fix if this is indeed an issue, but I’d like to discuss the best way to implement it first.
The text was updated successfully, but these errors were encountered: