Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Drag&Drop is stopped working #321

Closed
1 task done
dajotim937 opened this issue Jan 28, 2025 · 6 comments
Closed
1 task done

[Bug]: Drag&Drop is stopped working #321

dajotim937 opened this issue Jan 28, 2025 · 6 comments
Assignees
Labels
Milestone

Comments

@dajotim937
Copy link

Preflight Checklist

  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.

OpenComic Version

1.4.0

Operating System

Win10, 22H2, build 19045

Installed via

.exe

Steps to reproduce

  1. Drag & drop folder to open option

Expected Behavior

Open folder from OpenComic

Actual Behavior

Nothing happens.
And there is no message in debug console.

Error message

No response

Additional Information

No response

Sample file

No response

@dajotim937 dajotim937 added the bug label Jan 28, 2025
@ollm ollm self-assigned this Jan 28, 2025
@ollm ollm added this to the v1.4.1 milestone Jan 28, 2025
@ollm
Copy link
Owner

ollm commented Jan 28, 2025

Thanks for reporting!

This is due to a change in Electron version 32, which has a Breaking Change in Web File API electron/electron#42053, this should fix it a830bf8

Build: https://mega.nz/file/mXZnwaIB#t8v8yVk-fgZUiFQW_CpIktNUPUOtAo25rbFHzsriVKQ

@dajotim937
Copy link
Author

Yep, works fine both "Open" and "Add to library" options.

@dajotim937
Copy link
Author

Probably related:
Can't delete folder to trash (but can delete permanently).
If I try to move to trash I got dom.js:2305 Uncaught (in promise) Error: Failed to create FileOperation instance in dev console.

@ollm
Copy link
Owner

ollm commented Feb 3, 2025

It's a different electron bug, that seems to occur only on Windows electron/electron#29598

I have submitted the following fix 8c34a31 with the changes they recommend in electron/electron#29598 (comment)

Build: https://mega.nz/file/nCggUIRb#Ax3Ctp0HJiNNU5cqAugnr1Uns629TYJy0qfGq1dVE0c

@dajotim937
Copy link
Author

Move to trash is working fine for me now.

@ollm
Copy link
Owner

ollm commented Feb 8, 2025

Closed as fixed and available in v1.4.1

@ollm ollm closed this as completed Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants