Skip to content
This repository has been archived by the owner on Mar 4, 2018. It is now read-only.

Tests #38

Open
elijahverdoorn opened this issue Oct 27, 2017 · 4 comments
Open

Tests #38

elijahverdoorn opened this issue Oct 27, 2017 · 4 comments
Assignees
Milestone

Comments

@elijahverdoorn
Copy link
Member

We should have them. That requires someone to write them.

@rye rye self-assigned this Oct 27, 2017
@rye
Copy link
Contributor

rye commented Oct 27, 2017

Other people are welcome to self-assign.

@elijahverdoorn and I spoke a bit today about putting together something using Jest for the frontend, and didn't really decide about Mocha + Chai vs Jest. I'd be down to use either; Jest in both places would probably be nicer.

Whatever solution we choose should probably have support for mocking—I'm not yet familiar enough with Jest to know one way or the other which is the better option. I've used a bit of Mocha in the past and it was somewhat nice.

Also, we should test as much as possible, and I think our general philosophy should be pessimistic as to what kinds of contexts we're in.

It'd be nice to put in some pending tests (just specs, no body) and then to actually write the body.

@rye
Copy link
Contributor

rye commented Oct 31, 2017

Reading further, it looks like Mocha + Chai is more robust for business logic. We should, however, use Jest to test the client.

@rye
Copy link
Contributor

rye commented Oct 31, 2017

For now, though, I'll try implementing the tests in Jest. It seems simpler and less convoluted than adding two separate dependencies.

@elijahverdoorn
Copy link
Member Author

elijahverdoorn commented Oct 31, 2017

Take a look at supertest

@rye rye added this to the Version 1.0 milestone Jan 12, 2018
@rye rye modified the milestones: Version 0, Version 1 Feb 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants