Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why Don't merge will be ignored in review lists? #25

Open
kachick opened this issue Nov 20, 2017 · 3 comments
Open

Why Don't merge will be ignored in review lists? #25

kachick opened this issue Nov 20, 2017 · 3 comments

Comments

@kachick
Copy link

kachick commented Nov 20, 2017

In my understanding, WIP does not require coworker reviews. But Don't merge does not mean it. Don't merge finished the coding and needs reviews, but can not be merged from any reasons. How do you think it?

(If you have same thought with me, Other PRs of WIP should be ignored with another way? label or anything... 🤔 )

@ohbarye
Copy link
Owner

ohbarye commented Nov 20, 2017

But Don't merge does not mean it. Don't merge finished the coding and needs reviews, but can not be merged from any reasons. How do you think it?

I believe that's totally depends on a team. It's simply that Don't merge doesn't require review in our team so far.

Then if I propose a feature to ignore PRs by other way (e.g. to specify words to be ignored), would your problem be resolved? 🤔

@review-bot ls author:kachick -ignore-words:"WIP","RFC"

@kachick
Copy link
Author

kachick commented Nov 20, 2017

Sounds 😍

@ohbarye
Copy link
Owner

ohbarye commented Nov 20, 2017

Thanks for you opinion, give me some time. 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants