Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework magit faces #18

Open
ogdenwebb opened this issue Mar 24, 2019 · 4 comments
Open

Rework magit faces #18

ogdenwebb opened this issue Mar 24, 2019 · 4 comments
Assignees
Labels
defer deferred until some changes

Comments

@ogdenwebb
Copy link
Owner

Another thing I notice is in magit log, color changes between hunks are easier to read in light theme than in dark theme. Not quite a bug, but perhaps you might want to take a look too?

output-2019-03-22-10:17:41

Originally posted by @yiufung in #17 (comment)

@ogdenwebb ogdenwebb self-assigned this Mar 24, 2019
@ogdenwebb ogdenwebb added the defer deferred until some changes label Mar 24, 2019
ogdenwebb added a commit that referenced this issue Apr 14, 2019
@trev-dev
Copy link

A nit-picky thing from me on this issue, too, is the caret that denotes an open/closed drawer is smooshed, too.

@ogdenwebb
Copy link
Owner Author

@trev-dev hello. Please would you provide an example with this particular part to clarify your issue?

@trev-dev
Copy link

@ogdenwebb Sure! Here's a gif of me opening/closing magit "drawers". You can see the caret on the left. This is not unique to Kaolin and the easiest solution would be to make their color the same as the background.

kaolin-magit

@ogdenwebb
Copy link
Owner Author

@trev-dev looks like magit doesn't have its own faces for fringe (this area where you see these indicators) and use default fringe faces instead, so I can not modify this area [without custom workaround]. I think you could open an issue in the magit repository if you really need that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defer deferred until some changes
Projects
None yet
Development

No branches or pull requests

2 participants