[IMP] util.rename_xmlid : Adapt t-call and t-name References

When renaming a view, we should also update its references in other views where
it is used in t-call and t-name attributes. This ensures consistency and
prevents broken references in dependent views.

closes #116

Signed-off-by: Christophe Simonis (chs) <[email protected]>

Author: kmod-odoo

src/base/tests/test_util.py

@@ -1887,3 +1887,39 @@ def test_remove_view(self):
         util.invalidate(test_view_3)
         self.assertFalse(test_view_2.exists())
         self.assertNotIn('t-call="base.test_view_2"', test_view_3.arch_db)
+
+
+class TestRenameXMLID(UnitTestCase):
+    def test_rename_xmlid(self):
+        test_view_1 = self.env["ir.ui.view"].create(
+            {
+                "name": "test_view_1",
+                "type": "qweb",
+                "key": "base.test_view_1",
+                "arch": """
+                <t t-name="base.test_view_1">
+                    <div>Test View 1 Content</div>
+                </t>
+                """,
+            }
+        )
+        self.env["ir.model.data"].create(
+            {"name": "test_view_1", "module": "base", "model": "ir.ui.view", "res_id": test_view_1.id}
+        )
+        test_view_2 = self.env["ir.ui.view"].create(
+            {
+                "name": "test_view_2",
+                "type": "qweb",
+                "key": "base.test_view_2",
+                "arch": """
+                <t t-name="base.test_view_2">
+                    <t t-call="base.test_view_1"/>
+                    <div>Test View 2 Content</div>
+                </t>
+                """,
+            }
+        )
+        util.rename_xmlid(self.env.cr, "base.test_view_1", "base.rename_view")
+        util.invalidate(test_view_2)
+        self.assertIn('t-call="base.rename_view"', test_view_2.arch_db)
+        self.assertIn('t-name="base.rename_view"', test_view_1.arch_db)

src/util/records.py

@@ -804,6 +804,34 @@ def rename_xmlid(cr, old, new, noupdate=None, on_collision="fail"):
                 # Don't change the view keys unconditionally to avoid changing unrelated views.
                 cr.execute("UPDATE ir_ui_view SET key = %s WHERE key = %s", [new, old])
 
+                # Adapting t-call and t-name references in views
+                search_pattern = r"""\yt-(call|name)=(["']){}\2""".format(re.escape(old))
+                replace_pattern = r"t-\1=\2{}\2".format(new)
+                if version_gte("16.0"):
+                    arch_col = get_value_or_en_translation(cr, "ir_ui_view", "arch_db")
+                    replace_in_all_jsonb_values(
+                        cr,
+                        "ir_ui_view",
+                        "arch_db",
+                        PGRegexp(search_pattern),
+                        replace_pattern,
+                        extra_filter=cr.mogrify("{} ~ %s".format(arch_col), [search_pattern]).decode(),
+                    )
+                else:
+                    arch_col = "arch_db" if column_exists(cr, "ir_ui_view", "arch_db") else "arch"
+                    cr.execute(
+                        format_query(
+                            cr,
+                            """
+                            UPDATE ir_ui_view
+                               SET {arch} = regexp_replace({arch}, %s, %s, 'g')
+                             WHERE {arch} ~ %s
+                            """,
+                            arch=arch_col,
+                        ),
+                        [search_pattern, replace_pattern, search_pattern],
+                    )
+
         if model == "ir.ui.menu" and column_exists(cr, "res_users_settings", "homemenu_config"):
             query = """
                 UPDATE res_users_settings