[FIX] CF: Avoid getter crash on invalid sheet

The Evaluated CF getters would crash when provided an invalid sheet id.
Providing an inexisting or invalid col/row would not throw though.

This becomes an issue since #7634 because during the excel export, we
fetch the style of all the cells of *all the sheets*  in the data and
some of them are "ghost" sheets that are injected only in the export data.
As such, they are not part of the plugins lifecycle.

This revision fixes the getters for CF so that they don't throw on
invalid sheets for 2 reasons:
- coherence: bad xc does not throw but a bad sheet id does
- other style-related getters do not throw

closes #8229

Task: 0
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>

Author: rrahir

packages/o-spreadsheet-engine/src/plugins/ui_core_views/evaluation_conditional_format.ts

@@ -73,17 +73,17 @@ export class EvaluationConditionalFormatPlugin extends CoreViewPlugin {
 
   getCellConditionalFormatStyle(position: CellPosition): Style | undefined {
     const { sheetId, col, row } = position;
-    const styles = this.computedStyles[sheetId]();
+    const styles = this.computedStyles[sheetId]?.();
     return styles && styles[col]?.[row];
   }
 
   getConditionalIcon({ sheetId, col, row }: CellPosition): string | undefined {
-    const icons = this.computedIcons[sheetId]();
+    const icons = this.computedIcons[sheetId]?.();
     return icons && icons[col]?.[row];
   }
 
   getConditionalDataBar({ sheetId, col, row }: CellPosition): DataBarFill | undefined {
-    const dataBars = this.computedDataBars[sheetId]();
+    const dataBars = this.computedDataBars[sheetId]?.();
     return dataBars && dataBars[col]?.[row];
   }
 

tests/conditional_formatting/conditional_formatting_plugin.test.ts

@@ -5,7 +5,12 @@ import {
   ConditionalFormatRule,
   IconThreshold,
 } from "@odoo/o-spreadsheet-engine/types/conditional_formatting";
-import { CommandResult, ConditionalFormattingOperatorValues, UID } from "../../src/types";
+import {
+  CellPosition,
+  CommandResult,
+  ConditionalFormattingOperatorValues,
+  UID,
+} from "../../src/types";
 import {
   activateSheet,
   addCf,
@@ -2703,4 +2708,20 @@ describe("conditional formats types", () => {
     );
     expect(getStyle(model, "B1")).toEqual({ fillColor: undefined });
   });
+
+  test("Evaluated CF getters do not throw on invalid position", () => {
+    const model = new Model();
+    const badSheetIdPosition = toCellPosition("fakeSSheet", "A1");
+    expect(() => model.getters.getCellConditionalFormatStyle(badSheetIdPosition)).not.toThrow();
+    expect(() => model.getters.getConditionalIcon(badSheetIdPosition)).not.toThrow();
+    expect(() => model.getters.getConditionalDataBar(badSheetIdPosition)).not.toThrow();
+    const badXCPosition: CellPosition = {
+      sheetId: model.getters.getActiveSheetId(),
+      col: -1,
+      row: -1,
+    };
+    expect(() => model.getters.getCellConditionalFormatStyle(badXCPosition)).not.toThrow();
+    expect(() => model.getters.getConditionalIcon(badXCPosition)).not.toThrow();
+    expect(() => model.getters.getConditionalDataBar(badXCPosition)).not.toThrow();
+  });
 });