[FIX] DV: Allow use of cellPosition-related functions in rules

Currently, one cannot use the functions ROW() or COLUMN() in the rules
of their data validations. This revision provides the required cell
position to the formula evaluation context to support the evaluation of
those functions.

closes #8182

Task: 5868662
X-original-commit: 9342ebc
Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>

Author: rrahir

packages/o-spreadsheet-engine/src/plugins/ui_core_views/evaluation_data_validation.ts

@@ -241,7 +241,12 @@ export class EvaluationDataValidationPlugin extends CoreViewPlugin {
     const evaluator = criterionEvaluatorRegistry.get(criterion.type);
 
     const offset = this.getCellOffsetInRule(cellPosition, rule);
-    const evaluatedCriterionValues = this.getEvaluatedCriterionValues(sheetId, offset, criterion);
+    const evaluatedCriterionValues = this.getEvaluatedCriterionValues(
+      sheetId,
+      cellPosition,
+      offset,
+      criterion
+    );
     if (evaluatedCriterionValues.some(isMultipleElementMatrix)) {
       return undefined;
     }
@@ -283,6 +288,7 @@ export class EvaluationDataValidationPlugin extends CoreViewPlugin {
 
   private getEvaluatedCriterionValues(
     sheetId: UID,
+    cellPosition: CellPosition,
     offset: Offset,
     criterion: DataValidationCriterion
   ): (CellValue | Matrix<CellValue>)[] {
@@ -299,7 +305,7 @@ export class EvaluationDataValidationPlugin extends CoreViewPlugin {
         formula
       );
 
-      return this.getters.evaluateFormula(sheetId, translatedFormula);
+      return this.getters.evaluateFormula(sheetId, translatedFormula, cellPosition);
     });
   }
 }

tests/conditional_formatting/conditional_formatting_plugin.test.ts

@@ -2340,17 +2340,13 @@ describe("conditional formats types", () => {
       setCellContent(model, "B1", "2");
       setCellContent(model, "B2", "4");
 
-      model.dispatch("ADD_CONDITIONAL_FORMAT", {
-        sheetId,
-        ranges: toRangesData(sheetId, "A1:B2"),
-        cf: {
-          id: "1",
-          rule: {
-            type: "CellIsRule",
-            operator: "isEqual",
-            values: ["=ROW()*COLUMN()"],
-            style: { fillColor: "#00FF00" },
-          },
+      addCf(model, "A1:B2", {
+        id: "1",
+        rule: {
+          type: "CellIsRule",
+          operator: "isEqual",
+          values: ["=ROW()*COLUMN()"],
+          style: { fillColor: "#00FF00" },
         },
       });
       expect(getStyle(model, "A1")).toEqual({ fillColor: "#00FF00" });
@@ -2363,15 +2359,15 @@ describe("conditional formats types", () => {
       setCellContent(model, "A1", "1");
       setCellContent(model, "A2", "2");
 
-      model.dispatch("ADD_CONDITIONAL_FORMAT", {
-        sheetId,
-        ranges: toRangesData(sheetId, "A1:A2"),
-        cf: createColorScale(
+      addCf(
+        model,
+        "A1:B2",
+        createColorScale(
           "1",
           { type: "formula", color: 0xff0000, value: "=ROW()+1" },
           { type: "formula", color: 0x0000ff, value: "=ROW()+2" }
-        ),
-      });
+        )
+      );
       expect(getStyle(model, "A1")).toEqual({});
       expect(getStyle(model, "A2")).toEqual({});
     });

tests/data_validation/evaluation_data_validation_plugin.test.ts

@@ -7,6 +7,7 @@ import {
   setCellContent,
   setFormat,
 } from "../test_helpers/commands_helpers";
+import { setGrid, toCellPosition } from "../test_helpers/helpers";
 
 describe("Data validation evaluation", () => {
   let model: Model;
@@ -221,4 +222,33 @@ describe("Data validation evaluation", () => {
     setFormat(model, "A2", "mm/dd/yyyy");
     expect(model.getters.isDataValidationInvalid(A1)).toEqual(false);
   });
+
+  test("DV evaluation can be based on position-related formulas", () => {
+    const sheetId = model.getters.getActiveSheetId();
+    //prettier-ignore
+    setGrid(model, {
+      A1: "1", A2: "5", A3: "3", A4: "4",
+                        B3: "3", B4: "2", B5: "4", B6: "6",
+    });
+
+    addDataValidation(model, "A1:A4,B3:B6", "id", { type: "isEqual", values: ["=ROW()"] });
+    expect(model.getters.isDataValidationInvalid(toCellPosition(sheetId, "A1"))).toEqual(false);
+    expect(model.getters.isDataValidationInvalid(toCellPosition(sheetId, "A2"))).toEqual(true);
+    expect(model.getters.isDataValidationInvalid(toCellPosition(sheetId, "A3"))).toEqual(false);
+    expect(model.getters.isDataValidationInvalid(toCellPosition(sheetId, "A4"))).toEqual(false);
+    expect(model.getters.isDataValidationInvalid(toCellPosition(sheetId, "B3"))).toEqual(false);
+    expect(model.getters.isDataValidationInvalid(toCellPosition(sheetId, "B4"))).toEqual(true);
+    expect(model.getters.isDataValidationInvalid(toCellPosition(sheetId, "B5"))).toEqual(true);
+    expect(model.getters.isDataValidationInvalid(toCellPosition(sheetId, "B6"))).toEqual(false);
+
+    addDataValidation(model, "A1:B6", "id", { type: "isEqual", values: ["=ROW()"] });
+    expect(model.getters.isDataValidationInvalid(toCellPosition(sheetId, "A1"))).toEqual(false);
+    expect(model.getters.isDataValidationInvalid(toCellPosition(sheetId, "A2"))).toEqual(true);
+    expect(model.getters.isDataValidationInvalid(toCellPosition(sheetId, "A3"))).toEqual(false);
+    expect(model.getters.isDataValidationInvalid(toCellPosition(sheetId, "A4"))).toEqual(false);
+    expect(model.getters.isDataValidationInvalid(toCellPosition(sheetId, "B3"))).toEqual(false);
+    expect(model.getters.isDataValidationInvalid(toCellPosition(sheetId, "B4"))).toEqual(true);
+    expect(model.getters.isDataValidationInvalid(toCellPosition(sheetId, "B5"))).toEqual(true);
+    expect(model.getters.isDataValidationInvalid(toCellPosition(sheetId, "B6"))).toEqual(false);
+  });
 });