Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set verbatimModuleSyntax to true #15

Merged
merged 1 commit into from Jun 6, 2023
Merged

Set verbatimModuleSyntax to true #15

merged 1 commit into from Jun 6, 2023

Conversation

kfcampbell
Copy link
Member

BREAKING CHANGE: this will throw errors during Typescript compilation when types are not imported using the import type keywords.

See prior discussion on octokit/auth-token.js#345.

@kfcampbell kfcampbell requested review from gr2m and wolfy1339 June 6, 2023 19:14
@ghost ghost added this to Inbox in JS Jun 6, 2023
@ghost ghost moved this from Inbox to Features in JS Jun 6, 2023
@gr2m gr2m merged commit 6341002 into main Jun 6, 2023
3 checks passed
@gr2m gr2m deleted the verbatim-module-syntax branch June 6, 2023 21:27
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kfcampbell
Copy link
Member Author

@gr2m Do you have opinions about the following content from here? Should I add any of those to another PR on this repo?

  "compilerOptions": {
    "esModuleInterop": true,
    "declaration": true,
    "emitDeclarationOnly": true,
    "sourceMap": true,
  },
  "include": ["src/**/*"]

@oscard0m
Copy link
Member

oscard0m commented Jul 21, 2023

@gr2m Do you have opinions about the following content from here? Should I add any of those to another PR on this repo?

  "compilerOptions": {
    "esModuleInterop": true,
    "declaration": true,
    "emitDeclarationOnly": true,
    "sourceMap": true,
  },
  "include": ["src/**/*"]

👍🏽 on this. The more we centralize, the easier to maintain and standardise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
JS
  
Features
Development

Successfully merging this pull request may close these issues.

None yet

3 participants