You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have an application that's hitting the secondary rate limit even after adding this plugin. I'm passing the following to try to recover:
const octokit = new Octokit({
...
throttle: {
...
onSecondaryRateLimit: (retryAfter, options:any, octokit, retryCount) => {
octokit.log.warn(
`Secondary rate limit exceeded for request ${options.query}`,
);
if (retryCount < 1 && retryAfter <= 120) {
// Retry once and for at most 2 minutes.
console.info(`Retrying after ${retryAfter} seconds.`);
return true;
}
}
},
});
But even though I see Retrying after 60 seconds. in the output, other requests are getting sent before the 60s delay and predictably also hitting the secondary rate limit. https://github.com/SGrondin/bottleneck#retries seems to say this shouldn't happen, but I haven't traced the code enough to see why it might be happening anyway.
The text was updated successfully, but these errors were encountered:
I've been trying to find an alternative for Bottleneck for a while now, alas without success thus far. Bottleneck has not been updated for years. Unfortunately even if you find the culprit, it will be very unlikely a bugfix might be fixed and released.
We really have to figure this out @octokit/js-community @octokit/maintainers
I have an application that's hitting the secondary rate limit even after adding this plugin. I'm passing the following to try to recover:
But even though I see
Retrying after 60 seconds.
in the output, other requests are getting sent before the 60s delay and predictably also hitting the secondary rate limit. https://github.com/SGrondin/bottleneck#retries seems to say this shouldn't happen, but I haven't traced the code enough to see why it might be happening anyway.The text was updated successfully, but these errors were encountered: