Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert the change to drop support for Node 14 & 16 #390

Merged
merged 1 commit into from Jun 2, 2023

Conversation

wolfy1339
Copy link
Member

Resolves #389


Behavior

Before the change?

  • The package could not be installed on Node v14 or v16
  • Introduced a breaking change in a patch release

After the change?

  • Reverts the breaking change
  • Package can now be installed on Node v14 & 16 again

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Dependencies/code cleanup: Type: Maintenance

@wolfy1339 wolfy1339 added Type: Bug Something isn't working as documented Priority: High labels Jun 2, 2023
@ghost ghost added this to Bugs in JS Jun 2, 2023
@gr2m gr2m merged commit dae109a into main Jun 2, 2023
8 checks passed
@gr2m gr2m deleted the fix-revert-breaking-change branch June 2, 2023 19:04
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

🎉 This PR is included in version 2.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented
Projects
Archived in project
JS
  
Bugs
Development

Successfully merging this pull request may close these issues.

Accidental introduction of Breaking Change
2 participants