Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We do not filter out invalid repositories #19

Open
gr2m opened this issue Mar 5, 2021 · 0 comments
Open

We do not filter out invalid repositories #19

gr2m opened this issue Mar 5, 2021 · 0 comments

Comments

@gr2m
Copy link
Member

gr2m commented Mar 5, 2021

this is what happens when there are no tests 🤷

const invalidRepositories = repositories.filter((fullName) => {
/^[a-z0-9_.-]+\/([a-z0-9_.-]+|\*)$/i.test(fullName);
});

What this should be is

  const invalidRepositories = repositories.filter((fullName) => !/^[a-z0-9_.-]+\/([a-z0-9_.-]+|\*)$/i.test(fullName); 

Depending on what we decide in #18 we need to adjust the regex to match the * in different places in the repository name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant