Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable using token from ~/.netrc #14

Open
travi opened this issue Feb 26, 2021 · 2 comments
Open

enable using token from ~/.netrc #14

travi opened this issue Feb 26, 2021 · 2 comments

Comments

@travi
Copy link
Member

travi commented Feb 26, 2021

i'll try to get a PR together sometime soon to make this possible with octokit-auth-netrc

@gr2m
Copy link
Member

gr2m commented Feb 26, 2021

Let's talk about authentication in general. I was thinking to introduce a prompt to ask about authentication if the --octoherd-token CLI argument is not passed.

In that prompt, we can utilize octokit-auth-netrc to check if it finds a token and suggests that as an option.

The other options I'd like to start with:

  1. Enter a token
  2. Create a new token using @octokit/auth-oauth-device

Future ideas:

  1. Add option to authenticate using a GitHub app, either by entering App ID and Private Key or by using the GitHub App Manifest Flow to create a GitHub App. If we support GitHub App authentication we need to update the way we iterate through repositories
  2. Question: should we keep a session / multiple sessions, similar to other CLIs such as npm or gh. We could introduce octoherd login and run scripts using octoherd run. I haven't done this before though, so I wonder what the conventions and security considerations are here. I'd also like to keep Deno compatibility in mind, see Use Deno #5

@koalaty-code
Copy link
Contributor

With the recent introduction of support for GHES domains, octokit-auth-netrc will need to be updated to also support custom domains. I have opened a PR to support GHES domain in the netrc plugin: travi/octokit-auth-netrc#608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants