-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG][Tyxml] multiple a_class for a single element are not supported. #968
Labels
Comments
@Drup, is this something we would want to support in tyxml directly ? |
I'm not sure, do you have a pragmatic solution ? I feel like we should treat attributes as an string table, instead of an association list, and ask concrete implementation to do the right thing. |
I do not have any solution in mind, I didn't really think about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Given the following function:
calling
wrap ~a:[a_class [ "some-other-class" ]] some_contents
results in a structure having either only "wrapper" or "some-other-class".Expected behavior
The classes are gathered into a single list and properly reflect the final list of attributes, without having to separate classes, event handlers, and all others, in order to bundle them all at the lowest structure-creation level.
Versions
Ocaml: 4.08.1
Js_of_ocaml-tyxml: 3.5.2
The text was updated successfully, but these errors were encountered: