test: use oclif/test v4

Author: mdonnalley

package.json

@@ -8,15 +8,15 @@
     "@oclif/core": "^3.26.6"
   },
   "devDependencies": {
-    "@commitlint/config-conventional": "^18",
+    "@commitlint/config-conventional": "^19",
     "@oclif/plugin-help": "^6",
     "@oclif/prettier-config": "^0.2.1",
+    "@oclif/test": "^4.0.2",
     "@types/chai": "^4.3.11",
     "@types/mocha": "^10.0.6",
     "@types/node": "^18",
-    "@types/sinon": "^17.0.3",
     "chai": "^4.4.1",
-    "commitlint": "^18",
+    "commitlint": "^19",
     "eslint": "^8.57.0",
     "eslint-config-oclif": "^5.2.0",
     "eslint-config-oclif-typescript": "^3.1.7",
@@ -28,7 +28,6 @@
     "oclif": "^4.10.11",
     "prettier": "^3.2.5",
     "shx": "^0.3.4",
-    "sinon": "^17.0.2",
     "ts-node": "^10.9.2",
     "typescript": "^5.4.5"
   },

test/commands/which.test.ts

@@ -1,59 +1,40 @@
-import {Config, ux} from '@oclif/core'
+import {runCommand} from '@oclif/test'
 import {expect} from 'chai'
 import {dirname, join} from 'node:path'
 import {fileURLToPath} from 'node:url'
-import {SinonSandbox, createSandbox} from 'sinon'
 
 const root = join(dirname(fileURLToPath(import.meta.url)), '..', 'fixtures/test-plugin')
 
 describe('which', () => {
-  let sandbox: SinonSandbox
-  let config: Config
-
-  beforeEach(async () => {
-    sandbox = createSandbox()
-    sandbox.stub(ux.write, 'stdout')
-    config = await Config.load({root})
-  })
-
-  afterEach(async () => {
-    sandbox.restore()
-  })
-
-  it('should return plugin name for colon separate command', async () => {
-    const {plugin} = await config.runCommand<{plugin: string}>('which', ['foo:bar'])
-    expect(plugin).to.equal('test-plugin')
+  it('should return plugin name for colon separated command', async () => {
+    const {result} = await runCommand<{plugin: string}>('which foo:bar', {root})
+    expect(result?.plugin).to.equal('test-plugin')
   })
 
-  it('should return plugin name for quoted space separate command', async () => {
-    const {plugin} = await config.runCommand<{plugin: string}>('which', ['foo bar'])
-    expect(plugin).to.equal('test-plugin')
+  it('should return plugin name for quoted space separated command', async () => {
+    const {result} = await runCommand<{plugin: string}>('which "foo bar"', {root})
+    expect(result?.plugin).to.equal('test-plugin')
   })
 
-  it('should return plugin name for unquoted space separate command', async () => {
-    const {plugin} = await config.runCommand<{plugin: string}>('which', ['foo', 'bar'])
-    expect(plugin).to.equal('test-plugin')
+  it('should return plugin name for unquoted space separated command', async () => {
+    const {result} = await runCommand<{plugin: string}>('which foo bar', {root})
+    expect(result?.plugin).to.equal('test-plugin')
   })
 
   it('should return plugin name and aliasOf for alias', async () => {
-    const {aliasOf, plugin} = await config.runCommand<{aliasOf: string; plugin: string}>('which', ['foo:alias'])
-    expect(plugin).to.equal('test-plugin')
-    expect(aliasOf).to.equal('foo bar')
+    const {result} = await runCommand<{aliasOf: string; plugin: string}>('which foo:alias', {root})
+    expect(result?.plugin).to.equal('test-plugin')
+    expect(result?.aliasOf).to.equal('foo bar')
   })
 
   it('should not return aliasOf if not an alias', async () => {
-    const {aliasOf, plugin} = await config.runCommand<{aliasOf: string; plugin: string}>('which', ['foo:bar'])
-    expect(plugin).to.equal('test-plugin')
-    expect(aliasOf).to.be.undefined
+    const {result} = await runCommand<{aliasOf: string; plugin: string}>('which foo:bar', {root})
+    expect(result?.plugin).to.equal('test-plugin')
+    expect(result?.aliasOf).to.be.undefined
   })
 
   it('should throw error if no command is provided', async () => {
-    try {
-      await config.runCommand('which')
-      throw new Error('expected error')
-    } catch (error) {
-      const {message} = error as Error
-      expect(message).to.contain('"which" expects a command name')
-    }
+    const {error} = await runCommand('which', {root})
+    expect(error?.message).to.contain('"which" expects a command name')
   })
 })