Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added chanId to getComputeEnvironments url path. #1815

Closed
wants to merge 2 commits into from

Conversation

mariacarmina
Copy link
Member

Fixes #1814 .

Changes proposed in this PR:

  • Added chanId to getComputeEnvironments url path.

Copy link

codeclimate bot commented May 16, 2024

Code Climate has analyzed commit bfb7cf3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 75.6% (0.0% change).

View more on Code Climate.

Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mariacarmina
Copy link
Member Author

ocean.js depends on provider / endpoint which has the chain IDs hardcoded at the moment -> oceanprotocol/ocean-node#435

@mariacarmina
Copy link
Member Author

Will close this in favour of oceanprotocol/ocean-node#460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChainId field is not set as query parameter in URL path for c2d get envs call
2 participants