-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More tests for picos.sync
#83
Comments
It might be that the issue was related to the cancelation test spawning fibers, which translate to systhreads on OCaml 4. PR #230 changes the tests to not spawn fibers. Time will tell whether this eliminates the hangs on OCaml 4. Addition: There was a test run where the cancelation test did not seem to complete on 4.14 arm64. Not spawning lots of systhreads seems to have made the failures less common. |
@edwintorok mentioned about the |
I may have observed the
picos.sync
tests potentially dead/livelocking at least on (32-bit) OCaml 4.14 on CI. This might indicate a bug in thepicos.sync
library, a bug in the test, a bug in (32-bit) OCaml 4.14 (I don't recall seeing the test not completing on other OCaml versions, but I might have simply missed that), or it might be a completely unrelated thing (test machine being slow for some other reason). At any rate, this needs to be investigated further and the correctness of thepicos.sync
library implementation ensured.Observations:
debian-12-4.14_arm32_opam-2.1
(not completed after 24+ minutes, completed very quickly after cancel+rebuild)thread-local-storage
is (for some reason) not installed, it was possible, before Whenthreads.posix
exists we really needthread-local-storage
#110, to build a non-working set of libraries where the mutex cancelation test and benchmarks did not terminate. This shouldn't really be the case with the observed non-completion.debian-12-4.14_arm64_opam-2.1
(not completed in an hour)debian-12-4.14_opam-2.2
(seemed to be stuck in the cancelation test)The text was updated successfully, but these errors were encountered: