Skip to content

Add plugin: Tasks Calendar #5810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

aviatesk
Copy link

@aviatesk aviatesk commented Mar 24, 2025

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/aviatesk/obsidian-tasks-calendar

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@github-actions github-actions bot changed the title Update community-plugins.json Add plugin: Tasks Calendar Mar 24, 2025
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: BambusControl/obsidian-chronotyper. If you are submitting from a GitHub org, you need to be a public member of the org.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@ObsidianReviewBot
Copy link
Collaborator

ObsidianReviewBot commented Mar 25, 2025

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:The command name should not include the plugin name.

[1]:Do not detach leaves with your custom view in onunload, this is an antipattern, see: https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines#Don't+detach+leaves+in+%60onunload%60

(Skipped)


Optional

[1]:Casting to any should be avoided as much as possible.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Mar 25, 2025
@aviatesk
Copy link
Author

/skip The parts where styles are directly specified in JavaScript are all related to rendering "tooltip" elements. In the Tasks Calendar, the position of the tooltip that pops up when an event is clicked is calculated dynamically based on the current view size and the position of the event element, so it has to be done in JavaScript. That's why we can't specify it in CSS.

All other points have been addressed.

@github-actions github-actions bot added the Skipped code scan Code scanning skipped because submission is not in TS/author believes result is wrong label Mar 25, 2025
@joethei joethei assigned joethei and unassigned ObsidianReviewBot Apr 4, 2025
@joethei joethei added Minor changes requested PR can be merged after some final changes have been requested and removed Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Skipped code scan Code scanning skipped because submission is not in TS/author believes result is wrong labels Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes requested Minor changes requested PR can be merged after some final changes have been requested plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants