Skip to content

Add plugin: Image Share #5790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025
Merged

Add plugin: Image Share #5790

merged 2 commits into from
Apr 24, 2025

Conversation

iqijun
Copy link
Contributor

@iqijun iqijun commented Mar 23, 2025

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/iqijun/obsidian-image-share

Release Checklist
-[x] I have tested the plugin on

  • Windows
  • macOS
  • Linux
  • Android (if applicable)
  • iOS (if applicable)
    -[x] My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    -[x] main.js
    -[x] manifest.json
    -[x]styles.css (optional)
    -[x] GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
    -[x]The id in my manifest.json matches the id in the community-plugins.json file.
    -[x]My README.md describes the plugin's purpose and provides clear usage instructions.
    -[x] I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
    -[x]I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
    -[x] I have added a license in the LICENSE file.
    -[x] My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ The plugin ID is not valid. Only alphanumeric lowercase characters and dashes are allowed.
❌ Your latest Release is missing the main.js file.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Plugin ID mismatch, the ID in this PR (image-share) is not the same as the one in your repo (Image-share). If you just changed your plugin ID, remember to change it in the manifest.json in your repo and your latest GitHub release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@iqijun iqijun closed this Mar 23, 2025
@iqijun iqijun reopened this Mar 23, 2025
@github-actions github-actions bot changed the title Add plugin: Image share Add plugin: Image Share Mar 23, 2025
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21][22][23][24][25][26][27][28][29][30]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.

[1][2][3][4][5][6][7][8]:Using innerHTML, outerHTML or similar API's is a security risk. Instead, use the DOM API or the Obsidian helper functions: https://docs.obsidian.md/Plugins/User+interface/HTML+elements


Optional

[1][2]:Casting to any should be avoided as much as possible.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Mar 24, 2025
@iqijun iqijun closed this Mar 24, 2025
@iqijun iqijun reopened this Mar 24, 2025
@ObsidianReviewBot ObsidianReviewBot added Ready for review and removed Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Mar 24, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Mar 24, 2025
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, ready for additional review by human.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: wenlzhang/obsidian-canvas-format-brush. If you are submitting from a GitHub org, you need to be a public member of the org.


Warnings:

⚠️ Your repository does not include a license. It is generally recommended for open-source projects to have a license. Go to https://choosealicense.com/ to compare different open source licenses.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1][2][3][4][5][6][7][8][9][10][11]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot added Ready for review and removed Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Mar 26, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Mar 26, 2025
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, ready for additional review by human.

@joethei
Copy link
Collaborator

joethei commented Apr 11, 2025

# Obsidian Image-share Plugin
Naming something "Obsidian xyz" is reserved for first party products we create, please change this header.

"fundingUrl": "https://github.com/iqijun",
This is meant for links to services like Buy me a coffee, GitHub sponsors and so on, if you don't have such a link remove this line.

.modal {
Please don't overwrite core styling in a plugin, add another class/data attribute so it only applies to your plugin.

new Component()
You need to unload this component once the rendered result is no longer displayed, otherwise this will lead to a memory leak.

@joethei joethei self-assigned this Apr 11, 2025
@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Apr 11, 2025
@iqijun
Copy link
Contributor Author

iqijun commented Apr 12, 2025

# Obsidian Image-share Plugin Naming something "Obsidian xyz" is reserved for first party products we create, please change this header.

"fundingUrl": "https://github.com/iqijun", This is meant for links to services like Buy me a coffee, GitHub sponsors and so on, if you don't have such a link remove this line.

.modal { Please don't overwrite core styling in a plugin, add another class/data attribute so it only applies to your plugin.

new Component() You need to unload this component once the rendered result is no longer displayed, otherwise this will lead to a memory leak.

HI,I have fixed the problem. Please review it again.

@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Apr 12, 2025
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1][2][3][4]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Ready for review and removed Ready for review Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Apr 13, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Apr 13, 2025
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, ready for additional review by human.

@joethei joethei merged commit dadd839 into obsidianmd:master Apr 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants