Skip to content

Add plugin: Open Tab Settings #5789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

Conversation

jesse-r-s-hines
Copy link
Contributor

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/jesse-r-s-hines/obsidian-open-tab-settings

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ The authorUrl field in your manifest should not point to the Obsidian Website. If you don't have a website you can just point it to your GitHub profile.
❌ The fundingUrl field in your manifest should not point to the Obsidian Website, If you don't have a link were users can donate to you, you can just remove it from the manifest.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@ObsidianReviewBot
Copy link
Collaborator

ObsidianReviewBot commented Mar 23, 2025

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

(Skipped)


Optional

[1][2][3][4][5][6][7][8][9]:Casting to any should be avoided as much as possible.

[1]:Use app.fileManager.trashFile(file: TAbstractFile) instead, this will make sure that the file is deleted according to the users preferences.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Mar 23, 2025
@jesse-r-s-hines
Copy link
Contributor Author

/skip the scanner is picking up code in the plugins tests.

@github-actions github-actions bot added the Skipped code scan Code scanning skipped because submission is not in TS/author believes result is wrong label Mar 23, 2025
@jesse-r-s-hines
Copy link
Contributor Author

I've removed most of the any casts.

@ObsidianReviewBot ObsidianReviewBot added Ready for review and removed Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Mar 29, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Mar 29, 2025
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, ready for additional review by human.

@joethei
Copy link
Collaborator

joethei commented Apr 4, 2025

"author": "Obsidian",
Update this.

# Obsidian Open Tab Settings
Naming something "Obsidian xyz" is reserved for first party products we create, please change this header.

@joethei joethei self-assigned this Apr 4, 2025
@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review Skipped code scan Code scanning skipped because submission is not in TS/author believes result is wrong labels Apr 4, 2025
@jesse-r-s-hines
Copy link
Contributor Author

I've updated the author and header.

@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Minor changes requested PR can be merged after some final changes have been requested labels Apr 5, 2025
@joethei joethei merged commit 45bf580 into obsidianmd:master Apr 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants