Skip to content

Add plugin: Easy Copy #5787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025
Merged

Add plugin: Easy Copy #5787

merged 2 commits into from
Apr 24, 2025

Conversation

Moyf
Copy link
Contributor

@Moyf Moyf commented Mar 22, 2025

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/Moyf/easy-copy

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@github-actions github-actions bot changed the title Add Easy Copy Plugin Add plugin: Easy Copy Mar 22, 2025
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:We recommend against providing a default hotkey when possible. The reason being that it's easy to pick a hotkey that a user already has configured and they could get confused when that key doesn't do what they expect. Also, it's hard choosing a safe default hotkey that's available for all operating systems.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Ready for review and removed Ready for review Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Mar 23, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Mar 23, 2025
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, ready for additional review by human.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: wenlzhang/obsidian-canvas-format-brush. If you are submitting from a GitHub org, you need to be a public member of the org.


Warnings:

⚠️ Your repository does not include a license. It is generally recommended for open-source projects to have a license. Go to https://choosealicense.com/ to compare different open source licenses.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@Moyf
Copy link
Contributor Author

Moyf commented Mar 26, 2025

image

Well… Do I need to fix this "conflicts"?
I think I've fixed once, and it appeared again 🤔
image

@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:Lookbehinds are not supported in iOS versions before 16.4


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Ready for review and removed Ready for review Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Mar 26, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Mar 26, 2025
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, ready for additional review by human.

@joethei
Copy link
Collaborator

joethei commented Apr 11, 2025

'contextual-copy': 'Contextual Copy'
Use sentence case in UI

containerEl.createEl('h2', {text: this.plugin.t('format')});, containerEl.createEl('h2', {text: this.plugin.t('target')});
For section headings in settings use:

new Setting(containerEl).setName('name here').setHeading();

@joethei joethei self-assigned this Apr 11, 2025
@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Apr 11, 2025
@Moyf
Copy link
Contributor Author

Moyf commented Apr 12, 2025

'contextual-copy': 'Contextual Copy' Use sentence case in UI

containerEl.createEl('h2', {text: this.plugin.t('format')});, containerEl.createEl('h2', {text: this.plugin.t('target')}); For section headings in settings use:

new Setting(containerEl).setName('name here').setHeading();

Hi Joethei, thank you for your feedback!
I've made those changes here, and I kindly ask for your review. Best regards!

@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Apr 12, 2025
@joethei joethei merged commit 3996258 into obsidianmd:master Apr 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants