Add plugin: Manuscript Timeline

[EricRhysTaylor]

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/EricRhysTaylor/Obsidian-Manuscript-Timeline

Release Checklist

• I have tested the plugin on
  • Windows
  • [ x] macOS
  • Linux
  • Android (if applicable)
  • iOS (if applicable)
• My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
  • main.js
  • manifest.json
  • [n/a] styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
• [x ] The id in my manifest.json matches the id in the community-plugins.json file.
• [x ] My README.md describes the plugin's purpose and provides clear usage instructions.
• [x ] I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
• [x ] I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
• [x ] I have added a license in the LICENSE file.
• [x ] My project respects and is compatible with the original license of any code from other plugins that I'm using.
  I have given proper attribution to these other projects in my README.md.

[github-actions]

Hello!

I found the following issues in your plugin submission

Errors:

❌ Your latest Release is missing the main.js file.
❌ Your latest Release is missing the manifest.json file.

---

^{This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.}

[EricRhysTaylor]

files added to repository.

[github-actions]

Hello!

I found the following issues in your plugin submission

Errors:

❌ Unable to find a release with the tag 1.0.3. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.

---

^{This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.}

[EricRhysTaylor]

Published 1.0.3 release.

[ObsidianReviewBot]

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:Please remove the main.js file from the repo and add it to your .gitignore. Compiled release files shouldn't get mixed with source code in your commits and should go to the releases files instead.

[1]:The command name should not include the plugin name.

[1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.

[1][2]:Using innerHTML, outerHTML or similar API's is a security risk. Instead, use the DOM API or the Obsidian helper functions: https://docs.obsidian.md/Plugins/User+interface/HTML+elements

---

Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

[ObsidianReviewBot]

Changes requested by bot have been made, ready for additional review by human.

[github-actions]

Hello!

I found the following issues in your plugin submission

Errors:

❌ Could not parse community-plugins.json, invalid JSON. Expected property name or '}' in JSON at position 536800

---

^{This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.}

[github-actions]

Hello!

I found the following issues in your plugin submission

Errors:

❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: ankit-kapur/obsidian-kanban-status-updater-plugin. If you are submitting from a GitHub org, you need to be a public member of the org.

---

^{This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.}

[github-actions]

Hello!

I found the following issues in your plugin submission

Errors:

❌ Unable to find a release with the tag 1.1.0. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.

---

^{This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.}

[ObsidianReviewBot]

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21][22][23][24][25][26][27]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.

[1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21][22][23][24][25][26][27][28][29][30] and more :You should consider limiting the number of console.logs in your code, to not pollute the dev console.

---

Optional

[1][2]:Casting to any should be avoided as much as possible.

---

Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

[ObsidianReviewBot]

Changes requested by bot have been made, ready for additional review by human.

[joethei]

this.plugin
The component passed to MarkdownRenderer.render should not be the plugin instance.
Doing that leads to a memory leak, because new event listeners are registered, but never removed.
The component is responsible for the lifecycle handling of the event listeners related to the rendered result, so it should be unloaded once there is nothing being rendered anymore.

[EricRhysTaylor]

Hi Johannes, Thank you for catching this. I've updated the code. Let me know if there is anything else. Have a great weekend. -eric this.plugin was replaced with this as unknown as Component <https://github.com/EricRhysTaylor/Obsidian-Manuscript-Timeline/blob/4238cc8c3c045b9776668968c6ee86cb0998f705/main.ts#L5405> This change should resolve the memory leak issue. Details: 1. **The Core Change:** The essential fix was changing the last argument of `MarkdownRenderer.render` from `this.plugin` to `this`. This ensures that the lifecycle of the rendered Markdown content (and any associated event listeners created by the renderer) is tied to the `ManuscriptTimelineSettingTab` instance itself. 2. **Lifecycle Management:** Since `ManuscriptTimelineSettingTab` extends `PluginSettingTab`, which extends `Component`, Obsidian manages its lifecycle. When the user closes the settings tab, Obsidian will unload this specific component. 3. **Cleanup:** By passing `this` as the component context, `MarkdownRenderer.render` registers its cleanup routines (like removing event listeners) to be executed when *this specific settings tab component* is unloaded. 4. **The Cast (`as unknown as Component`):** This part was purely to satisfy the TypeScript compiler's type checking. It doesn't change the underlying JavaScript behavior at runtime. We're still passing the settings tab instance, which is what matters for fixing the leak. So, when the settings tab is closed and its component is unloaded, the resources used by the `MarkdownRenderer` for that specific instance should now be properly released, preventing the memory leak.

…

On Thu, Apr 24, 2025 at 12:11 PM Johannes Theiner ***@***.***> wrote: *joethei* left a comment (obsidianmd/obsidian-releases#5782) <#5782 (comment)> this.plugin <https://github.com/EricRhysTaylor/Obsidian-Manuscript-Timeline/blob/356654a8b357c23b7a05dae9bef9881bc0183758/main.ts#L5360> The component passed to MarkdownRenderer.render should not be the plugin instance. Doing that leads to a memory leak, because new event listeners are registered, but never removed. The component is responsible for the lifecycle handling of the event listeners related to the rendered result, so it should be unloaded once there is nothing being rendered anymore. — Reply to this email directly, view it on GitHub <#5782 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BEFCPC6D2HP463YIRAGRIWD23EZPNAVCNFSM6AAAAABZRGL44CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMRYGYYTQNRSGQ> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>