Skip to content

Add plugin: Floating Settings #5779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

wambo121
Copy link

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/wambo121/Floating-Settings-for-Obsidian

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: wenlzhang/obsidian-file-title-updater. If you are submitting from a GitHub org, you need to be a public member of the org.


Warnings:

⚠️ Your repository does not include a license. It is generally recommended for open-source projects to have a license. Go to https://choosealicense.com/ to compare different open source licenses.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Please don't use the word plugin in the plugin ID. The ID is used for your plugin's folder so keeping it short and simple avoids clutter and helps with sorting.
❌ Please don't use the word Plugin in the plugin name since it's redundant and adds clutter to the plugin list.
❌ Unable to find a release with the tag 1.0.0. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@wambo121 wambo121 closed this Mar 21, 2025
@wambo121 wambo121 reopened this Mar 21, 2025
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Please don't use the word plugin in the plugin ID. The ID is used for your plugin's folder so keeping it short and simple avoids clutter and helps with sorting.
❌ Please don't use the word Plugin in the plugin name since it's redundant and adds clutter to the plugin list.


Warnings:

⚠️ Your repository does not include a license. It is generally recommended for open-source projects to have a license. Go to https://choosealicense.com/ to compare different open source licenses.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@wambo121 wambo121 closed this Mar 21, 2025
@wambo121 wambo121 reopened this Mar 21, 2025
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Please don't use the word plugin in the plugin ID. The ID is used for your plugin's folder so keeping it short and simple avoids clutter and helps with sorting.
❌ Please don't use the word Plugin in the plugin name since it's redundant and adds clutter to the plugin list.
❌ Plugin ID mismatch, the ID in this PR (floating-settings-plugin) is not the same as the one in your repo (floating-settings). If you just changed your plugin ID, remember to change it in the manifest.json in your repo and your latest GitHub release.
❌ Plugin name mismatch, the name in this PR (Floating Settings Plugin) is not the same as the one in your repo (Floating Settings). If you just changed your plugin name, remember to change it in the manifest.json in your repo and your latest GitHub release.
❌ The authorUrl field in your manifest should not point to the GitHub repository of the plugin.


Warnings:

⚠️ Your repository does not include a license. It is generally recommended for open-source projects to have a license. Go to https://choosealicense.com/ to compare different open source licenses.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@wambo121 wambo121 closed this Mar 21, 2025
@wambo121 wambo121 reopened this Mar 21, 2025
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Please don't use the word plugin in the plugin ID. The ID is used for your plugin's folder so keeping it short and simple avoids clutter and helps with sorting.
❌ Please don't use the word Plugin in the plugin name since it's redundant and adds clutter to the plugin list.
❌ Plugin ID mismatch, the ID in this PR (floating-settings-plugin) is not the same as the one in your repo (floating-settings). If you just changed your plugin ID, remember to change it in the manifest.json in your repo and your latest GitHub release.
❌ Plugin name mismatch, the name in this PR (Floating Settings Plugin) is not the same as the one in your repo (Floating Settings). If you just changed your plugin name, remember to change it in the manifest.json in your repo and your latest GitHub release.


Warnings:

⚠️ Your repository does not include a license. It is generally recommended for open-source projects to have a license. Go to https://choosealicense.com/ to compare different open source licenses.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@wambo121 wambo121 closed this Mar 21, 2025
@wambo121 wambo121 reopened this Mar 21, 2025
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Please don't use the word plugin in the plugin ID. The ID is used for your plugin's folder so keeping it short and simple avoids clutter and helps with sorting.
❌ Please don't use the word Plugin in the plugin name since it's redundant and adds clutter to the plugin list.
❌ Plugin ID mismatch, the ID in this PR (floating-settings-plugin) is not the same as the one in your repo (floating-settings). If you just changed your plugin ID, remember to change it in the manifest.json in your repo and your latest GitHub release.
❌ Plugin name mismatch, the name in this PR (Floating Settings Plugin) is not the same as the one in your repo (Floating Settings). If you just changed your plugin name, remember to change it in the manifest.json in your repo and your latest GitHub release.


Warnings:

⚠️ Your repository does not include a license. It is generally recommended for open-source projects to have a license. Go to https://choosealicense.com/ to compare different open source licenses.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hello!

I found the following issues in your plugin submission

Warnings:

⚠️ Your repository does not include a license. It is generally recommended for open-source projects to have a license. Go to https://choosealicense.com/ to compare different open source licenses.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@github-actions github-actions bot changed the title Add my-plugin to community plugins Add plugin: Floating Settings Mar 21, 2025
@wambo121 wambo121 closed this Mar 21, 2025
@wambo121 wambo121 reopened this Mar 21, 2025
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:Please remove the main.js file from the repo and add it to your .gitignore. Compiled release files shouldn't get mixed with source code in your commits and should go to the releases files instead.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Mar 22, 2025
@ObsidianReviewBot ObsidianReviewBot added Ready for review and removed Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Mar 22, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Mar 22, 2025
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, ready for additional review by human.

@wambo121
Copy link
Author

Hi, this is my first plugin submission 😊
Let me know if anything is missing or needs improvement.
I've already updated it to v 1.1.0 with needed improvement to the plugin's functions.
Thanks for your awesome work!

@joethei
Copy link
Collaborator

joethei commented Apr 11, 2025

"authorUrl": "wambo121/Floating-Settings-for-Obsidian",
That's not a valid URL, and also it should not link to the plugin repo, but your GitHub profile / website.

'Open Settings in New Window'
Use sentence case in UI

// Inject custom styles into the popout window
This should be in the styles.css file

@joethei joethei self-assigned this Apr 11, 2025
@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes requested Minor changes requested PR can be merged after some final changes have been requested plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants