Add plugin: VCF Contacts

[broekema41]

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/broekema41/obsidian-vcf-contacts/

Release Checklist

• I have tested the plugin on
  • Windows
  • macOS
  • Linux
  • Android (if applicable)
  • iOS (if applicable)
• My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
  • main.js
  • manifest.json
  • styles.css (optional)
• GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
• The id in my manifest.json matches the id in the community-plugins.json file.
• My README.md describes the plugin's purpose and provides clear usage instructions.
• I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
• I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
• I have added a license in the LICENSE file.
• My project respects and is compatible with the original license of any code from other plugins that I'm using.
  I have given proper attribution to these other projects in my README.md.

[github-actions]

Hello!

I found the following issues in your plugin submission

Errors:

❌ Please don't use the word obsidian in the plugin ID. The ID is used for your plugin's folder so keeping it short and simple avoids clutter and helps with sorting.
❌ Please don't include Obsidian in the plugin description
❌ Your plugin has a long description. Users typically find it difficult to read a very long description, so you should keep it short and concise.
❌ Unable to find a release with the tag 1.0.0. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.

---

^{This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.}

[ObsidianReviewBot]

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:Do not detach leaves with your custom view in onunload, this is an antipattern, see: https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines#Don't+detach+leaves+in+%60onunload%60

[1][2]:Using innerHTML, outerHTML or similar API's is a security risk. Instead, use the DOM API or the Obsidian helper functions: https://docs.obsidian.md/Plugins/User+interface/HTML+elements

[1]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.

[1]:You should not cast this, instead use a instanceof check to make sure that it's actually a file/folder.

---

Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

[broekema41]

This afternoon I have updated, created release 2.0.1 resolving all the review bot items.
Hoping for a listing soon. regards, Ro

[broekema41]

Hello @joethei @Zachatoo Noticed that you two have allot on your plate trying to keep the plugin ecosystem going and its quality up. I will await my turn and monitor this pull request on a regular basis. regards, Ro

[broekema41]

Released version 2.0.2 with avatar processing.
https://github.com/broekema41/obsidian-vcf-contacts/releases/tag/2.0.2

[ObsidianReviewBot]

Changes requested by bot have been made, ready for additional review by human.

[joethei]

Please credit the original author in your README and manifest.

Copyright (c) 2022 Vadim Beskrovnov
Update this, but keep the original copyright intact.

"description": "Effortlessly manage, organize, and interact with your contacts inside Obsidian. Import, export, and structure vCard (VCF) files seamlessly while keeping all contact details accessible in your knowledge base. Includes click-to-call, right-click copy, structured metadata, and more!",
Don't include "Obsidian" in the description.

let debounceTimer: NodeJS.Timeout;
Use a regular number as the type here, and use window.setTimeout / window.clearTimeout where this is being used.

aria-label="Create New Contact", aria-label="Sort By Birthday", aria-label="Sort By Organization", item.setTitle("Copy to Clipboard")
Use sentence case in UI

containerEl.createEl('h2', { text: 'Settings for "Contacts" plugin.' });
Don't add a top-level heading in the settings tab, such as "General", "Settings", or the name of your plugin.

const yamlString = yaml.dump(recordWithoutNote, { lineWidth: -1 });
Use the stringifyYaml function from the Obsidian API instead of importing a library.

const content = await app.vault.read(file);
Use the processFrontMatter function for this, (require minAppVersion: "1.1.0")

[broekema41]

Thank you for the feedback @joethei

Made corrections for all the items mentioned and released version 2.0.3:
https://github.com/broekema41/obsidian-vcf-contacts/releases/tag/2.0.3

A overview of the file changes can be found at:
https://github.com/broekema41/obsidian-vcf-contacts/pull/3/files

[broekema41]

good day @joethei, is there anything I should do here? Just noticed that my comment rectification of the review items was 3 weeks ago. Thanks Roland

[ObsidianReviewBot]

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.

---

Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

[github-actions]

Hello!

I found the following issues in your plugin submission

Errors:

❌ Could not parse community-plugins.json, invalid JSON. Expected ',' or ']' after array element in JSON at position 612503

---

^{This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.}