Add plugin: Private Mode

[markusmo3]

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/markusmo3/obsidian-private-mode

Release Checklist

• I have tested the plugin on
  • Windows
  • macOS
  • Linux
  • Android (if applicable)
  • iOS (if applicable)
• My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
  • main.js
  • manifest.json
  • styles.css (optional)
• GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
• The id in my manifest.json matches the id in the community-plugins.json file.
• My README.md describes the plugin's purpose and provides clear usage instructions.
• I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
• I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
• I have added a license in the LICENSE file.
• My project respects and is compatible with the original license of any code from other plugins that I'm using.
  I have given proper attribution to these other projects in my README.md.

[ObsidianReviewBot]

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1][2]:We recommend against providing a default hotkey when possible. The reason being that it's easy to pick a hotkey that a user already has configured and they could get confused when that key doesn't do what they expect. Also, it's hard choosing a safe default hotkey that's available for all operating systems.

---

Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

[github-actions]

Hello!

I found the following issues in your plugin submission

Errors:

❌ Could not parse community-plugins.json, invalid JSON. Expected ',' or ']' after array element in JSON at position 579051

---

^{This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.}

[ObsidianReviewBot]

Changes requested by bot have been made, ready for additional review by human.

[Zachatoo]

this.statusBar.ariaLabel = "Toggle Private Mode"
Use sentence case in UI

id: "private-mode-hide-private",, id: "private-mode-reveal-on-hover",, id: "private-mode-reveal-all",, id: "private-mode-cycle",, id: "private-mode-toggle-screenshare-protection",
Don't prefix the command id with the plugin id, Obsidian will make sure that there are no conflicts with other plugins.

[markusmo3]

@Zachatoo Whoops, must have missed those. Thanks for catching em! I fixed the mentioned problems in 1.1.6

[ObsidianReviewBot]

Changes requested by Zachatoo have been made, assigning additional human for additional review

[joethei]

Copyright (c) 2024 markusmo3
Update this.

if (window.require !== undefined) {
Please add a check that Platform.isDesktop
Oh, and please mention that this specific feature only works on desktop in your README.

addIcon("eye", eyeIcon);, addIcon("eye-closed", eyeClosedIcon);
Please change the identifier here, they are already in use by Lucide, the icon library we use.
Or use the Lucide icons for this and remove these custom icons.

[markusmo3]

I chose Platform.isDesktopApp instead, as the documentation says it ensure an "electron" app is running, which is what i am requiring there.

And the icon naming is now to the standard from where i got it: https://icon-sets.iconify.design/ph/eye-closed/ ala ph--eye-closed with the ph-- prefix