Skip to content

Add plugin: Image to HTML #5635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2025
Merged

Add plugin: Image to HTML #5635

merged 3 commits into from
Mar 25, 2025

Conversation

0x1DA9430
Copy link
Contributor

@0x1DA9430 0x1DA9430 commented Mar 9, 2025

I am submitting a new Community Plugin

Repo URL

Link to my plugin:
https://github.com/0x1DA9430/obsidian-img2html

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, ready for manual review.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: yingflower/obsidian-stu-repo-helper. If you are submitting from a GitHub org, you need to be a public member of the org.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@joethei
Copy link
Collaborator

joethei commented Mar 19, 2025

# Obsidian Image to HTML, # Obsidian Image to HTML
Naming something "Obsidian xyz" is reserved for first party products we create, please change this header.

// 监听语言变更, updateI18n() {
This is not necessary, the entire app, including all plugin's get's reloaded when the user changes the language in the app settings.

name: 'Image Width',, name: 'Use Custom Image Path',, name: 'Custom Image Path',, name: 'Include alt Attribute',, name: 'Show Notification',
Use sentence case in UI

containerEl.createEl('h2', {text: i18n.settings.title});
Don't add a top-level heading in the settings tab, such as "General", "Settings", or the name of your plugin.

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Mar 19, 2025
@joethei joethei assigned joethei and unassigned ObsidianReviewBot Mar 19, 2025
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Could not parse community-plugins.json, invalid JSON. Unexpected token ']', ..."2html"
},
]

" is not valid JSON


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@0x1DA9430
Copy link
Contributor Author

# Obsidian Image to HTML, # Obsidian Image to HTML Naming something "Obsidian xyz" is reserved for first party products we create, please change this header.

// 监听语言变更, updateI18n() { This is not necessary, the entire app, including all plugin's get's reloaded when the user changes the language in the app settings.

name: 'Image Width',, name: 'Use Custom Image Path',, name: 'Custom Image Path',, name: 'Include alt Attribute',, name: 'Show Notification', Use sentence case in UI

containerEl.createEl('h2', {text: i18n.settings.title}); Don't add a top-level heading in the settings tab, such as "General", "Settings", or the name of your plugin.

Thanks for the review! I've made the requested changes. Let me know if there's anything else you'd like me to update.

@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Mar 22, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Mar 23, 2025
@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, ready for manual review.

@joethei joethei merged commit 4f7216e into obsidianmd:master Mar 25, 2025
1 check passed
@0x1DA9430 0x1DA9430 deleted the patch-1 branch March 27, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants